-
Notifications
You must be signed in to change notification settings - Fork 25
Deprecate the repository and pip package #231
Conversation
@farhan Could you please look at the test failure. |
@salman2013 fixed |
bc4c0c9
to
5c239df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farhan we should also remove the old code from these files and replace it with wildcard imports of the new locations. That way we are not maintaining two copies of the code that can get out of sync and the shell of xblock-utils continues to work as we make changes in the upstream repo.
5c239df
to
497dfe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is on the right track and should be good to land once the tests have been fixed and you've tested locally that an XBlock that still uses xblock-utils runs and produces the expected warnings.
@feanil test cases fixed
🤔 |
@farhan yea, once we're happy with this, we can drop all the tests but it's useful to have them to make sure we did all the import redirecting correctly. It makes sense that those tests would need to be updated because of how the ResourceLoader class is being imported now within the XBlock library but it was good to verify we didn't break any non-test functionality of calling the imports the old way in the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great, I left a minor suggestion in the language of the import warning that you can take or leave. Feel free to merge and make a final release of this repo.
Co-authored-by: Feanil Patel <[email protected]>
Ticket: openedx/XBlock#675
PR implementation details:
Add a deprecation warning in:
For readme preview:
https://github.com/openedx/xblock-utils/blob/farhan/deprecate-repo/README.rst
Implementation inspiration:
https://github.com/openedx/edx-platform/blob/master/docs/decisions/0007-sys-path-modification-removal.rst
https://github.com/openedx/edx-platform/tree/open-release/koa.1/import_shims
How deprecated warning will appear in the console: