Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Add retry logic to retrieve_latest_base_ami request #717

Closed
1 task
robrap opened this issue Nov 30, 2023 · 0 comments
Closed
1 task

Add retry logic to retrieve_latest_base_ami request #717

robrap opened this issue Nov 30, 2023 · 0 comments
Assignees

Comments

@robrap
Copy link
Contributor

robrap commented Nov 30, 2023

AC:

  • Auto retry the request in tubular retrieve_latest_base_ami.

Notes:

The request here sometimes fails: https://github.com/openedx/tubular/blob/master/tubular/scripts/retrieve_latest_base_ami.py#L83.

Retry logic could be added by refactoring out that call to a new decorated method using:

@backoff.on_exception(
    backoff.expo,
    requests.exceptions.RequestException,
    max_tries=5, jitter=backoff.random_jitter, on_backoff=_backoff_logger,
)
@robrap robrap added this to Arch-BOM Nov 30, 2023
@robrap robrap moved this to Prioritized in Arch-BOM Nov 30, 2023
@robrap robrap removed the status in Arch-BOM Nov 30, 2023
@robrap robrap moved this to On-Call in Arch-BOM Dec 4, 2023
@rgraber rgraber moved this from On-Call to In Progress in Arch-BOM Dec 11, 2023
@rgraber rgraber self-assigned this Dec 11, 2023
@rgraber rgraber moved this from In Progress to Done in Arch-BOM Dec 11, 2023
@rgraber rgraber closed this as completed Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants