Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

chore: add catalog-info and enable blank PR #626

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

ichintanjoshi
Copy link
Contributor

Description

  • added catalog-info.yaml
  • changed github issue template file

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 20, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ichintanjoshi
Copy link
Contributor Author

@sarina let me know if this is up to the mark

@ichintanjoshi ichintanjoshi requested a review from sarina June 20, 2024 13:05
@sarina
Copy link
Contributor

sarina commented Jun 20, 2024

Hi @ichintanjoshi - when I said "squash to two commits", I was looking for a commit history of two logical commits where each commit does exactly one thing. It would look like this:

chore: enable blank pull requests
chore: add catalog-info

But seeing as you're learning rebasing and squashing now, I'll just merge this. I recommend you go to your original branch and see if you can figure out how to get your original commit history down to these two.

@sarina sarina merged commit 3913884 into openedx-unsupported:master Jun 20, 2024
6 checks passed
@openedx-webhooks
Copy link

@ichintanjoshi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ichintanjoshi ichintanjoshi deleted the add-catalog-info branch June 21, 2024 05:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants