Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

docs: update superuser username in the getting_started.rst file #1149

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

hsinkoff
Copy link
Contributor

@hsinkoff hsinkoff commented Aug 9, 2023

Update the docs to include the correct email domain for the username.

I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)
  • N/A

@openedx-webhooks
Copy link

Thanks for the pull request, @hsinkoff! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 9, 2023
@itsjeyd
Copy link

itsjeyd commented Aug 15, 2023

Hey @hsinkoff, it looks like the PR bot marked this as an open source contribution, and I'm wondering if that's correct (based on the fact that you're a member of both https://github.com/edx and https://github.com/openedx)?

Please let me know if you think we can remove the label.

CC @mphilbrick211

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Aug 15, 2023
@hsinkoff
Copy link
Contributor Author

itsjeyd,

I believe that the open-source-contribution label can be removed. @jristau1984 is helping me get added to the correct group so that will not show up on future PRs.

@itsjeyd itsjeyd removed the open-source-contribution PR author is not from Axim or 2U label Aug 16, 2023
@itsjeyd
Copy link

itsjeyd commented Aug 16, 2023

@hsinkoff OK, I removed the label.

@hsinkoff hsinkoff changed the title docs: update superuser username in getting_started.rst docs: update superuser username in the getting_started.rst file Aug 16, 2023
@hsinkoff hsinkoff requested a review from rgraber August 21, 2023 15:11
@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Aug 22, 2023
Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgraber rgraber force-pushed the edit-superuser-username-in-docs branch from b536861 to db4c53e Compare August 24, 2023 16:24
@rgraber
Copy link
Contributor

rgraber commented Aug 24, 2023

Not sure why it's failing the Mac ci check. Checking with arch-bom.

@rgraber rgraber force-pushed the edit-superuser-username-in-docs branch from db4c53e to ea8d53f Compare August 30, 2023 13:24
@rgraber rgraber force-pushed the edit-superuser-username-in-docs branch from ea8d53f to b0dde64 Compare August 30, 2023 19:23
@rgraber rgraber merged commit 8b4b8a1 into master Aug 31, 2023
9 of 10 checks passed
@rgraber rgraber deleted the edit-superuser-username-in-docs branch August 31, 2023 12:15
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants