From 34373dec6d3aab5b2a3ac635dcc94942509abafa Mon Sep 17 00:00:00 2001 From: "zxBCN Valeriu_Tuguran,Constantin (IT EDP) EXTERNAL" Date: Tue, 26 Sep 2023 15:23:08 +0200 Subject: [PATCH 1/2] EDPC-1816 Check TODO. --- .../provision/authentication/TestAuthentication.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/test/java/org/opendevstack/provision/authentication/TestAuthentication.java b/src/test/java/org/opendevstack/provision/authentication/TestAuthentication.java index 12067ce1..96596f52 100644 --- a/src/test/java/org/opendevstack/provision/authentication/TestAuthentication.java +++ b/src/test/java/org/opendevstack/provision/authentication/TestAuthentication.java @@ -32,7 +32,6 @@ public String getName() { @Override public Collection getAuthorities() { if (authorities != null) { - // TODO check if we need to return a new list of auths return authorities; } else { List auths = new ArrayList<>(); From bd329edb553de5263dcc1c610bccfbbf20b12db8 Mon Sep 17 00:00:00 2001 From: "zxBCN Valeriu_Tuguran,Constantin (IT EDP) EXTERNAL" Date: Tue, 26 Sep 2023 15:26:43 +0200 Subject: [PATCH 2/2] EDPC-1816 Check TODO. --- .../provision/authentication/filter/SSOAuthProcessingFilter.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/org/opendevstack/provision/authentication/filter/SSOAuthProcessingFilter.java b/src/main/java/org/opendevstack/provision/authentication/filter/SSOAuthProcessingFilter.java index 90f5a89f..e9fd012c 100644 --- a/src/main/java/org/opendevstack/provision/authentication/filter/SSOAuthProcessingFilter.java +++ b/src/main/java/org/opendevstack/provision/authentication/filter/SSOAuthProcessingFilter.java @@ -89,7 +89,6 @@ boolean storeTokenIfCrowdMethodUsed( HttpServletRequest request, HttpServletResponse response, Authentication authResult) { if (authResult instanceof CrowdSSOAuthenticationToken && authResult.getCredentials() != null) { try { - // TODO check if this suffices super.storeTokenIfCrowd(request, response, authResult); return true; } catch (Exception e) {