From f4f0c6beb1d55483914e2aba82e56fd1939f0eba Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Fri, 13 Dec 2024 13:50:34 -0500 Subject: [PATCH 1/9] Resolve remaining issues from UI review --- .../searchSelector/SearchSelector.tsx | 4 +- frontend/src/components/table/TableBase.tsx | 2 +- .../dashboard/DashboardHelpTooltip.tsx | 9 ++-- .../codeEditor/DashboardCodeEditor.tsx | 4 +- .../pipelinesDetails/PipelineDetailsYAML.tsx | 1 + .../pipeline/PipelineDetails.tsx | 2 +- .../tables/experiment/ExperimentTableRow.tsx | 5 +- frontend/src/pages/ApplicationsPage.tsx | 6 ++- .../connectionTypes/ConnectionTypesPage.tsx | 2 +- frontend/src/pages/home/HomeHint.tsx | 8 ++- .../src/pages/home/projects/ProjectCard.tsx | 6 ++- .../screens/RegisterModel/RegisterModel.tsx | 22 ++++---- .../RegisterModel/RegistrationFormFooter.tsx | 51 +++++++++++++------ .../ModelRegistriesTableRow.tsx | 2 +- .../ModelRegistryTableRowStatus.tsx | 11 ++-- .../deployedModels/DeployedModelCard.tsx | 2 +- .../screens/projects/ProjectListView.tsx | 1 - .../projects/screens/projects/ProjectView.tsx | 1 - 18 files changed, 87 insertions(+), 52 deletions(-) diff --git a/frontend/src/components/searchSelector/SearchSelector.tsx b/frontend/src/components/searchSelector/SearchSelector.tsx index 2d3854b57a..976c1603ce 100644 --- a/frontend/src/components/searchSelector/SearchSelector.tsx +++ b/frontend/src/components/searchSelector/SearchSelector.tsx @@ -63,7 +63,7 @@ const SearchSelector: React.FC = ({ const toggleRef = React.useRef(null); const menuRef = React.useRef(null); const searchRef = React.useRef(null); - const popperProps = { minWidth, maxWidth: 'trigger', appendTo: 'inline' }; + const popperProps = { minWidth, maxWidth: 'trigger' }; return ( = ({ )} - + {typeof children === 'function' ? children({ menuClose: () => setIsOpen(false) }) diff --git a/frontend/src/components/table/TableBase.tsx b/frontend/src/components/table/TableBase.tsx index cb311268ed..4bc82bedfc 100644 --- a/frontend/src/components/table/TableBase.tsx +++ b/frontend/src/components/table/TableBase.tsx @@ -272,7 +272,7 @@ const TableBase = ({ {caption && {caption}} {/* Note from PF: following custom style can be removed when we can resolve misalignment issue natively */} - + {columns.map((col, i) => renderColumnHeader(col, i))} {subColumns?.length ? ( diff --git a/frontend/src/concepts/dashboard/DashboardHelpTooltip.tsx b/frontend/src/concepts/dashboard/DashboardHelpTooltip.tsx index 033d1d657d..2a29624794 100644 --- a/frontend/src/concepts/dashboard/DashboardHelpTooltip.tsx +++ b/frontend/src/concepts/dashboard/DashboardHelpTooltip.tsx @@ -1,15 +1,16 @@ import * as React from 'react'; -import { Tooltip } from '@patternfly/react-core'; +import { Popover } from '@patternfly/react-core'; import { OutlinedQuestionCircleIcon } from '@patternfly/react-icons'; +import DashboardPopupIconButton from './DashboardPopupIconButton'; type DashboardHelpTooltipProps = { content: React.ReactNode; }; const DashboardHelpTooltip: React.FC = ({ content }) => ( - - - + + } aria-label="More info" /> + ); export default DashboardHelpTooltip; diff --git a/frontend/src/concepts/dashboard/codeEditor/DashboardCodeEditor.tsx b/frontend/src/concepts/dashboard/codeEditor/DashboardCodeEditor.tsx index 99ea01c549..58a70f3b49 100644 --- a/frontend/src/concepts/dashboard/codeEditor/DashboardCodeEditor.tsx +++ b/frontend/src/concepts/dashboard/codeEditor/DashboardCodeEditor.tsx @@ -9,16 +9,18 @@ loader.config({ monaco }); type DashboardCodeEditorProps = Omit & { testId?: string; + codeEditorHeight?: string; }; const DashboardCodeEditor: React.FC> = ({ // 38px is the code editor toolbar height+border // calculate the div height to avoid container scrolling height = 'calc(100% - 38px)', + codeEditorHeight = '400px', ...props }) => (
- +
); diff --git a/frontend/src/concepts/pipelines/content/pipelinesDetails/PipelineDetailsYAML.tsx b/frontend/src/concepts/pipelines/content/pipelinesDetails/PipelineDetailsYAML.tsx index 643cab2511..f1b4262b57 100644 --- a/frontend/src/concepts/pipelines/content/pipelinesDetails/PipelineDetailsYAML.tsx +++ b/frontend/src/concepts/pipelines/content/pipelinesDetails/PipelineDetailsYAML.tsx @@ -47,6 +47,7 @@ const PipelineDetailsYAML: React.FC = ({ isLanguageLabelVisible language={Language.yaml} isReadOnly + codeEditorHeight="100%" /> ); }; diff --git a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineDetails.tsx b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineDetails.tsx index 897d53b8aa..3eeb1f13fd 100644 --- a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineDetails.tsx +++ b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineDetails.tsx @@ -171,7 +171,7 @@ const PipelineDetails: PipelineCoreDetailsPageComponent = ({ breadcrumbPath }) = hasBodyWrapper={false} isFilled padding={{ default: 'noPadding' }} - style={{ flexBasis: 0, overflowY: 'hidden' }} + style={{ flexBasis: 0 }} > = ({ = ({ } state={{ experiment }} > - {/* TODO: Remove the custom className after upgrading to PFv6 */} - + {/* TODO: Remove the inline style for underline once https://github.com/patternfly/patternfly/issues/7255 is resolved and PF versions are updated */} + } description={experiment.description} diff --git a/frontend/src/pages/ApplicationsPage.tsx b/frontend/src/pages/ApplicationsPage.tsx index 64db623390..e244b279dd 100644 --- a/frontend/src/pages/ApplicationsPage.tsx +++ b/frontend/src/pages/ApplicationsPage.tsx @@ -148,7 +148,11 @@ const ApplicationsPage: React.FC = ({ {!noHeader && renderHeader()} - + {renderContents()} diff --git a/frontend/src/pages/connectionTypes/ConnectionTypesPage.tsx b/frontend/src/pages/connectionTypes/ConnectionTypesPage.tsx index 6d1f2306cd..c421ea0e2c 100644 --- a/frontend/src/pages/connectionTypes/ConnectionTypesPage.tsx +++ b/frontend/src/pages/connectionTypes/ConnectionTypesPage.tsx @@ -22,7 +22,7 @@ const ConnectionTypesPage: React.FC = () => { description="Create and manage connection types for users in your organization. Connection types include customizable fields and optional default values to decrease the time required to add connections to data sources and sinks." errorMessage="Unable to load connection types" > - + diff --git a/frontend/src/pages/home/HomeHint.tsx b/frontend/src/pages/home/HomeHint.tsx index e0fb91d395..79d7370d07 100644 --- a/frontend/src/pages/home/HomeHint.tsx +++ b/frontend/src/pages/home/HomeHint.tsx @@ -63,7 +63,13 @@ const HomeHint: React.FC = () => { data-testid="jupyter-hint-icon" src={jupyterImg} alt="Jupyter" - style={{ height: 42, maxWidth: 'unset' }} + style={{ + height: 42, + maxWidth: 'unset', + backgroundColor: 'var(--pf-t--color--white)', + padding: 'var(--pf-t--global--spacer--xs)', + borderRadius: 'var(--pf-t--global--border--radius--small)', + }} /> diff --git a/frontend/src/pages/home/projects/ProjectCard.tsx b/frontend/src/pages/home/projects/ProjectCard.tsx index 767265b466..daae3cb2bb 100644 --- a/frontend/src/pages/home/projects/ProjectCard.tsx +++ b/frontend/src/pages/home/projects/ProjectCard.tsx @@ -44,7 +44,11 @@ const ProjectCard: React.FC = ({ project }) => { }} style={{ fontSize: 'var(--pf-t--global--font--size--body--default)' }} > - + diff --git a/frontend/src/pages/modelRegistry/screens/RegisterModel/RegisterModel.tsx b/frontend/src/pages/modelRegistry/screens/RegisterModel/RegisterModel.tsx index d79db22e9e..ea4734b342 100644 --- a/frontend/src/pages/modelRegistry/screens/RegisterModel/RegisterModel.tsx +++ b/frontend/src/pages/modelRegistry/screens/RegisterModel/RegisterModel.tsx @@ -127,19 +127,19 @@ const RegisterModel: React.FC = () => { /> - + ); }; diff --git a/frontend/src/pages/modelRegistry/screens/RegisterModel/RegistrationFormFooter.tsx b/frontend/src/pages/modelRegistry/screens/RegisterModel/RegistrationFormFooter.tsx index 2974121aa4..5282c399a8 100644 --- a/frontend/src/pages/modelRegistry/screens/RegisterModel/RegistrationFormFooter.tsx +++ b/frontend/src/pages/modelRegistry/screens/RegisterModel/RegistrationFormFooter.tsx @@ -1,6 +1,14 @@ import React from 'react'; -import { PageSection, Stack, StackItem, ActionGroup, Button } from '@patternfly/react-core'; import RegisterModelErrors from './RegisterModelErrors'; +import { + PageSection, + Stack, + StackItem, + Button, + ActionList, + ActionListItem, + ActionListGroup, +} from '@patternfly/react-core'; type RegistrationFormFooterProps = { submitLabel: string; @@ -37,21 +45,32 @@ const RegistrationFormFooter: React.FC = ({ /> )} - - - - + + + + + + + + + + diff --git a/frontend/src/pages/modelRegistrySettings/ModelRegistriesTableRow.tsx b/frontend/src/pages/modelRegistrySettings/ModelRegistriesTableRow.tsx index 7b785b8b3a..1c63bd8e09 100644 --- a/frontend/src/pages/modelRegistrySettings/ModelRegistriesTableRow.tsx +++ b/frontend/src/pages/modelRegistrySettings/ModelRegistriesTableRow.tsx @@ -28,7 +28,7 @@ const ModelRegistriesTableRow: React.FC = ({ ); return ( - + diff --git a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx index 570ba153c7..dad2e163b8 100644 --- a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx +++ b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx @@ -43,7 +43,7 @@ export const ModelRegistryTableRowStatus: React.FC; - let color: React.ComponentProps['color'] = 'blue'; + let status: React.ComponentProps['status'] = undefined; let popoverMessages: string[] = []; let popoverTitle = ''; @@ -71,26 +71,25 @@ export const ModelRegistryTableRowStatus: React.FC; - color = 'orangered'; + status = 'warning'; } // Degrading else if (degradedCondition?.status === ConditionStatus.True) { statusLabel = ModelRegistryStatusLabel.Degrading; icon = ; - color = 'grey'; popoverTitle = 'Service is degrading'; } // Available else if (availableCondition?.status === ConditionStatus.True) { statusLabel = ModelRegistryStatusLabel.Available; icon = ; - color = 'green'; + status = 'success'; } // Progressing else if (progressCondition?.status === ConditionStatus.True) { statusLabel = ModelRegistryStatusLabel.Progressing; icon = ; - color = 'blue'; + status = 'info'; } } // Handle popover logic for Unavailable status @@ -133,7 +132,7 @@ export const ModelRegistryTableRowStatus: React.FC {statusLabel} diff --git a/frontend/src/pages/projects/screens/detail/overview/serverModels/deployedModels/DeployedModelCard.tsx b/frontend/src/pages/projects/screens/detail/overview/serverModels/deployedModels/DeployedModelCard.tsx index 697bfef1c0..e2f7fc7d63 100644 --- a/frontend/src/pages/projects/screens/detail/overview/serverModels/deployedModels/DeployedModelCard.tsx +++ b/frontend/src/pages/projects/screens/detail/overview/serverModels/deployedModels/DeployedModelCard.tsx @@ -48,7 +48,7 @@ const DeployedModelCard: React.FC = ({ return ( - + diff --git a/frontend/src/pages/projects/screens/projects/ProjectListView.tsx b/frontend/src/pages/projects/screens/projects/ProjectListView.tsx index 12d5bfd443..7ee1d3e522 100644 --- a/frontend/src/pages/projects/screens/projects/ProjectListView.tsx +++ b/frontend/src/pages/projects/screens/projects/ProjectListView.tsx @@ -72,7 +72,6 @@ const ProjectListView: React.FC = ({ allowCreate }) => { { empty={projects.length === 0} emptyStatePage={} provideChildrenPadding - removeChildrenTopPadding > From 0566f6c9a4de6cb7b94c2b0beb7a27d83d0ea546 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Mon, 16 Dec 2024 08:17:53 -0500 Subject: [PATCH 2/9] Resolve lint errors --- frontend/src/components/table/TableBase.tsx | 4 +--- .../screens/RegisterModel/RegistrationFormFooter.tsx | 2 +- .../modelRegistrySettings/ModelRegistryTableRowStatus.tsx | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/frontend/src/components/table/TableBase.tsx b/frontend/src/components/table/TableBase.tsx index 4bc82bedfc..8d44e6b90a 100644 --- a/frontend/src/components/table/TableBase.tsx +++ b/frontend/src/components/table/TableBase.tsx @@ -272,9 +272,7 @@ const TableBase = ({ {caption && } {/* Note from PF: following custom style can be removed when we can resolve misalignment issue natively */} - - {columns.map((col, i) => renderColumnHeader(col, i))} - + {columns.map((col, i) => renderColumnHeader(col, i))} {subColumns?.length ? ( {subColumns.map((col, i) => renderColumnHeader(col, columns.length + i, true))} ) : null} diff --git a/frontend/src/pages/modelRegistry/screens/RegisterModel/RegistrationFormFooter.tsx b/frontend/src/pages/modelRegistry/screens/RegisterModel/RegistrationFormFooter.tsx index 5282c399a8..3430df9ef0 100644 --- a/frontend/src/pages/modelRegistry/screens/RegisterModel/RegistrationFormFooter.tsx +++ b/frontend/src/pages/modelRegistry/screens/RegisterModel/RegistrationFormFooter.tsx @@ -1,5 +1,4 @@ import React from 'react'; -import RegisterModelErrors from './RegisterModelErrors'; import { PageSection, Stack, @@ -9,6 +8,7 @@ import { ActionListItem, ActionListGroup, } from '@patternfly/react-core'; +import RegisterModelErrors from './RegisterModelErrors'; type RegistrationFormFooterProps = { submitLabel: string; diff --git a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx index dad2e163b8..3ee9f1dea0 100644 --- a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx +++ b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx @@ -43,7 +43,7 @@ export const ModelRegistryTableRowStatus: React.FC; - let status: React.ComponentProps['status'] = undefined; + let status: React.ComponentProps['status']; let popoverMessages: string[] = []; let popoverTitle = ''; From b776b39d628ad28c36c9424e5de4861a423db53e Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Mon, 16 Dec 2024 09:59:26 -0500 Subject: [PATCH 3/9] Resolve cypress failures Resolve cypress failures Resolve cypress failures --- .../__tests__/cypress/cypress/pages/pipelines/createRunPage.ts | 1 + .../cypress/pages/pipelines/pipelineVersionImportModal.ts | 2 +- .../src/__tests__/cypress/cypress/pages/pipelines/topology.ts | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/frontend/src/__tests__/cypress/cypress/pages/pipelines/createRunPage.ts b/frontend/src/__tests__/cypress/cypress/pages/pipelines/createRunPage.ts index 0c679b7c40..7cebaef51d 100644 --- a/frontend/src/__tests__/cypress/cypress/pages/pipelines/createRunPage.ts +++ b/frontend/src/__tests__/cypress/cypress/pages/pipelines/createRunPage.ts @@ -57,6 +57,7 @@ export class CreateRunPage { findPipelineVersionByName(name: string): Cypress.Chainable> { return this.find() + .document() .findByTestId('pipeline-version-selector-table-list') .find('td') .contains(name); diff --git a/frontend/src/__tests__/cypress/cypress/pages/pipelines/pipelineVersionImportModal.ts b/frontend/src/__tests__/cypress/cypress/pages/pipelines/pipelineVersionImportModal.ts index c4196bcf21..81a84bc995 100644 --- a/frontend/src/__tests__/cypress/cypress/pages/pipelines/pipelineVersionImportModal.ts +++ b/frontend/src/__tests__/cypress/cypress/pages/pipelines/pipelineVersionImportModal.ts @@ -58,7 +58,7 @@ class PipelineImportModal extends Modal { this.pipelineSelector .findToggleButton() .click() - .parents() + .document() .findByTestId('pipeline-selector-table-list') .find('tr') .contains(name) diff --git a/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts b/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts index e265579708..7e36e1c046 100644 --- a/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts +++ b/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts @@ -166,7 +166,7 @@ class PipelineDetails extends PipelinesTopology { this.pipelineVersionSelector .findToggleButton() .click() - .parents() + .document() .findByTestId('pipeline-version-selector-table-list') .find('td') .contains(name) From 914969a267ade024163c89e4677d4d5d6ba973cb Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Mon, 16 Dec 2024 14:00:51 -0500 Subject: [PATCH 4/9] Updated chart and form styling --- .../DWStatusOverviewDonutChart.tsx | 2 +- ...lDistributedWorkloadsWorkloadStatusTab.tsx | 2 +- .../screens/RegisterModel/RegisterVersion.tsx | 20 +++++++++---------- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/frontend/src/pages/distributedWorkloads/global/workloadStatus/DWStatusOverviewDonutChart.tsx b/frontend/src/pages/distributedWorkloads/global/workloadStatus/DWStatusOverviewDonutChart.tsx index d1d2f27e8f..c7f8d90e28 100644 --- a/frontend/src/pages/distributedWorkloads/global/workloadStatus/DWStatusOverviewDonutChart.tsx +++ b/frontend/src/pages/distributedWorkloads/global/workloadStatus/DWStatusOverviewDonutChart.tsx @@ -39,7 +39,7 @@ export const DWStatusOverviewDonutChart: React.FC = () => { ); } return ( -
+
( Status overview - + diff --git a/frontend/src/pages/modelRegistry/screens/RegisterModel/RegisterVersion.tsx b/frontend/src/pages/modelRegistry/screens/RegisterModel/RegisterVersion.tsx index 07c1feac1c..53d8aaa5a9 100644 --- a/frontend/src/pages/modelRegistry/screens/RegisterModel/RegisterVersion.tsx +++ b/frontend/src/pages/modelRegistry/screens/RegisterModel/RegisterVersion.tsx @@ -142,18 +142,18 @@ const RegisterVersion: React.FC = () => { /> - + ); }; From 93035e87f8f368878c6b080d85c56a355c14883c Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Tue, 17 Dec 2024 10:24:42 -0500 Subject: [PATCH 5/9] Additional resolutions from design review --- frontend/src/components/table/TableRowTitleDescription.tsx | 2 +- .../global/projectMetrics/sections/DWSectionCard.tsx | 2 +- .../global/workloadStatus/DWStatusOverviewDonutChart.tsx | 3 ++- frontend/src/pages/storageClasses/StorageClassesTableRow.tsx | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/frontend/src/components/table/TableRowTitleDescription.tsx b/frontend/src/components/table/TableRowTitleDescription.tsx index 46796ee4fb..0fd68ceec7 100644 --- a/frontend/src/components/table/TableRowTitleDescription.tsx +++ b/frontend/src/components/table/TableRowTitleDescription.tsx @@ -19,7 +19,7 @@ type TableRowTitleDescriptionProps = { const TableRowTitleDescription: React.FC = ({ title, - boldTitle = true, + boldTitle = false, titleIcon, description, resource, diff --git a/frontend/src/pages/distributedWorkloads/global/projectMetrics/sections/DWSectionCard.tsx b/frontend/src/pages/distributedWorkloads/global/projectMetrics/sections/DWSectionCard.tsx index 738c4bdd90..447e968efd 100644 --- a/frontend/src/pages/distributedWorkloads/global/projectMetrics/sections/DWSectionCard.tsx +++ b/frontend/src/pages/distributedWorkloads/global/projectMetrics/sections/DWSectionCard.tsx @@ -11,7 +11,7 @@ export const DWSectionCard: React.FC<{ - + {title} {helpTooltip ? : null} diff --git a/frontend/src/pages/distributedWorkloads/global/workloadStatus/DWStatusOverviewDonutChart.tsx b/frontend/src/pages/distributedWorkloads/global/workloadStatus/DWStatusOverviewDonutChart.tsx index c7f8d90e28..dc583e7be0 100644 --- a/frontend/src/pages/distributedWorkloads/global/workloadStatus/DWStatusOverviewDonutChart.tsx +++ b/frontend/src/pages/distributedWorkloads/global/workloadStatus/DWStatusOverviewDonutChart.tsx @@ -39,7 +39,8 @@ export const DWStatusOverviewDonutChart: React.FC = () => { ); } return ( -
+ // maxWidth matches what the chart's svg width value would be without the default "width: 100%" coming from PF Charts +
= ({
{caption}
- + {metadata.name} @@ -191,6 +191,7 @@ export const StorageClassesTableRow: React.FC = ({ } aria-label="Storage class info popover" + hasNoPadding /> From a9a8e529f548b9d0956eaba9c965ccbeae8a9f59 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Wed, 18 Dec 2024 06:52:44 -0500 Subject: [PATCH 6/9] Update styling for storage classes help button --- frontend/src/pages/storageClasses/StorageClassesTableRow.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/pages/storageClasses/StorageClassesTableRow.tsx b/frontend/src/pages/storageClasses/StorageClassesTableRow.tsx index 508f11e65e..0107a1714a 100644 --- a/frontend/src/pages/storageClasses/StorageClassesTableRow.tsx +++ b/frontend/src/pages/storageClasses/StorageClassesTableRow.tsx @@ -191,7 +191,7 @@ export const StorageClassesTableRow: React.FC = ({ } aria-label="Storage class info popover" - hasNoPadding + style={{ paddingBlock: 0 }} /> From ab305499f927d376ddee1aee5f9b83dd6d0e9937 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Thu, 19 Dec 2024 09:01:20 -0500 Subject: [PATCH 7/9] Remove boldTitle prop and resolve code editor cutoff --- frontend/src/components/table/TableRowTitleDescription.tsx | 4 +--- .../pipelinesDetails/pipelineRun/PipelineRunDetailsTabs.tsx | 2 +- .../content/tables/experiment/ExperimentTableRow.tsx | 1 - .../src/pages/connectionTypes/ConnectionTypesTableRow.tsx | 1 - .../manage/ManageConnectionTypeFieldsTableRow.tsx | 2 -- .../screens/detail/connections/ConnectionsTableRow.tsx | 1 - .../src/pages/projects/screens/projects/ProjectTableRow.tsx | 1 - 7 files changed, 2 insertions(+), 10 deletions(-) diff --git a/frontend/src/components/table/TableRowTitleDescription.tsx b/frontend/src/components/table/TableRowTitleDescription.tsx index 0fd68ceec7..01d44458d5 100644 --- a/frontend/src/components/table/TableRowTitleDescription.tsx +++ b/frontend/src/components/table/TableRowTitleDescription.tsx @@ -6,7 +6,6 @@ import TruncatedText from '~/components/TruncatedText'; type TableRowTitleDescriptionProps = { title: React.ReactNode; - boldTitle?: boolean; titleIcon?: React.ReactNode; resource?: K8sResourceCommon; subtitle?: React.ReactNode; @@ -19,7 +18,6 @@ type TableRowTitleDescriptionProps = { const TableRowTitleDescription: React.FC = ({ title, - boldTitle = false, titleIcon, description, resource, @@ -50,7 +48,7 @@ const TableRowTitleDescription: React.FC = ({ return (
-
+
{resource ? ( {title} diff --git a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsTabs.tsx b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsTabs.tsx index daf0b6e93a..f27a2f8d57 100644 --- a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsTabs.tsx +++ b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsTabs.tsx @@ -49,7 +49,7 @@ export const PipelineRunDetailsTabs: React.FC = ({ hasBodyWrapper={false} isFilled padding={{ default: 'noPadding' }} - style={{ flexBasis: 0, overflowY: 'hidden' }} + style={{ flexBasis: 0 }} > = ({
= ({
} description={getDescriptionFromK8sResource(obj)} truncateDescriptionLines={2} diff --git a/frontend/src/pages/connectionTypes/manage/ManageConnectionTypeFieldsTableRow.tsx b/frontend/src/pages/connectionTypes/manage/ManageConnectionTypeFieldsTableRow.tsx index 9a8bd26a93..92a9876375 100644 --- a/frontend/src/pages/connectionTypes/manage/ManageConnectionTypeFieldsTableRow.tsx +++ b/frontend/src/pages/connectionTypes/manage/ManageConnectionTypeFieldsTableRow.tsx @@ -64,7 +64,6 @@ const ManageConnectionTypeFieldsTableRow: React.FC = ({ /> @@ -132,7 +131,6 @@ const ManageConnectionTypeFieldsTableRow: React.FC = ({ /> } description={row.description} truncateDescriptionLines={2} diff --git a/frontend/src/pages/projects/screens/detail/connections/ConnectionsTableRow.tsx b/frontend/src/pages/projects/screens/detail/connections/ConnectionsTableRow.tsx index 1cd0eb1adb..5743bdc4cb 100644 --- a/frontend/src/pages/projects/screens/detail/connections/ConnectionsTableRow.tsx +++ b/frontend/src/pages/projects/screens/detail/connections/ConnectionsTableRow.tsx @@ -41,7 +41,6 @@ const ConnectionsTableRow: React.FC = ({ } - boldTitle={false} titleIcon={ showWarningIcon ? ( diff --git a/frontend/src/pages/projects/screens/projects/ProjectTableRow.tsx b/frontend/src/pages/projects/screens/projects/ProjectTableRow.tsx index a2763e6b5e..0236fb94de 100644 --- a/frontend/src/pages/projects/screens/projects/ProjectTableRow.tsx +++ b/frontend/src/pages/projects/screens/projects/ProjectTableRow.tsx @@ -71,7 +71,6 @@ const ProjectTableRow: React.FC = ({
From e7d6468d08244832547634a51e524cbd21dba21f Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Thu, 19 Dec 2024 09:42:52 -0500 Subject: [PATCH 8/9] Update rhoai logo --- frontend/src/images/rhoai-logo.svg | 53 +++++++++++++++--------------- 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/frontend/src/images/rhoai-logo.svg b/frontend/src/images/rhoai-logo.svg index e14ae8008d..97149e846c 100644 --- a/frontend/src/images/rhoai-logo.svg +++ b/frontend/src/images/rhoai-logo.svg @@ -8,48 +8,47 @@ - - - - - - - - - - - + + + + + + @@ -61,10 +60,10 @@ - Date: Mon, 6 Jan 2025 10:49:13 -0500 Subject: [PATCH 9/9] Fix registModel test failures --- .../cypress/pages/components/subComponents/SearchSelector.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/__tests__/cypress/cypress/pages/components/subComponents/SearchSelector.ts b/frontend/src/__tests__/cypress/cypress/pages/components/subComponents/SearchSelector.ts index ce3fd9ac35..a2a21502eb 100644 --- a/frontend/src/__tests__/cypress/cypress/pages/components/subComponents/SearchSelector.ts +++ b/frontend/src/__tests__/cypress/cypress/pages/components/subComponents/SearchSelector.ts @@ -6,7 +6,7 @@ export class SearchSelector extends SubComponentBase { } private findContextualItem(suffix: string): Cypress.Chainable> { - return this.findScope().findByTestId(`${this.selectorId}-${suffix}`); + return this.findScope().document().findByTestId(`${this.selectorId}-${suffix}`); } findItem(name: string, useMenuList: boolean): Cypress.Chainable> {