From 241863f1250920e72938d21f6a72a9520061e1f2 Mon Sep 17 00:00:00 2001 From: gitdallas <5322142+gitdallas@users.noreply.github.com> Date: Thu, 29 Aug 2024 10:27:33 -0500 Subject: [PATCH] feat(MR detail): truncate description in header Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com> --- .../screens/ModelVersionDetails/ModelVersionDetails.tsx | 4 ++-- .../modelRegistry/screens/ModelVersions/ModelVersions.tsx | 4 ++-- .../ModelVersionsArchive/ModelVersionArchiveDetails.tsx | 4 ++-- .../RegisteredModelsArchive/RegisteredModelArchiveDetails.tsx | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetails.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetails.tsx index 26b3f6c2a1..a54bb93504 100644 --- a/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetails.tsx +++ b/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetails.tsx @@ -1,6 +1,6 @@ import React from 'react'; import { useNavigate, useParams } from 'react-router'; -import { Breadcrumb, BreadcrumbItem, Flex, FlexItem } from '@patternfly/react-core'; +import { Breadcrumb, BreadcrumbItem, Flex, FlexItem, Truncate } from '@patternfly/react-core'; import { Link } from 'react-router-dom'; import ApplicationsPage from '~/pages/ApplicationsPage'; import useModelVersionById from '~/concepts/modelRegistry/apiHooks/useModelVersionById'; @@ -90,7 +90,7 @@ const ModelVersionsDetails: React.FC = ({ tab, ...page ) } - description={mv?.description} + description={} loadError={mvLoadError} loaded={mvLoaded} provideChildrenPadding diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersions.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersions.tsx index c7a030a707..b86fa15fdf 100644 --- a/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersions.tsx +++ b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersions.tsx @@ -1,6 +1,6 @@ import React from 'react'; import { useParams } from 'react-router'; -import { Breadcrumb, BreadcrumbItem } from '@patternfly/react-core'; +import { Breadcrumb, BreadcrumbItem, Truncate } from '@patternfly/react-core'; import { Link } from 'react-router-dom'; import ApplicationsPage from '~/pages/ApplicationsPage'; import useModelVersionsByRegisteredModel from '~/concepts/modelRegistry/apiHooks/useModelVersionsByRegisteredModel'; @@ -45,7 +45,7 @@ const ModelVersions: React.FC = ({ tab, ...pageProps }) => { } title={rm?.name} headerAction={rm && } - description={rm?.description} + description={} loadError={loadError} loaded={loaded} provideChildrenPadding diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionsArchive/ModelVersionArchiveDetails.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersionsArchive/ModelVersionArchiveDetails.tsx index 19c3f5319d..b522672092 100644 --- a/frontend/src/pages/modelRegistry/screens/ModelVersionsArchive/ModelVersionArchiveDetails.tsx +++ b/frontend/src/pages/modelRegistry/screens/ModelVersionsArchive/ModelVersionArchiveDetails.tsx @@ -1,6 +1,6 @@ import React from 'react'; import { useNavigate, useParams } from 'react-router'; -import { Button, Flex, FlexItem, Label, Text } from '@patternfly/react-core'; +import { Button, Flex, FlexItem, Label, Text, Truncate } from '@patternfly/react-core'; import ApplicationsPage from '~/pages/ApplicationsPage'; import useModelVersionById from '~/concepts/modelRegistry/apiHooks/useModelVersionById'; import { ModelRegistrySelectorContext } from '~/concepts/modelRegistry/context/ModelRegistrySelectorContext'; @@ -69,7 +69,7 @@ const ModelVersionsArchiveDetails: React.FC = Restore version } - description={mv?.description} + description={} loadError={mvLoadError} loaded={mvLoaded} provideChildrenPadding diff --git a/frontend/src/pages/modelRegistry/screens/RegisteredModelsArchive/RegisteredModelArchiveDetails.tsx b/frontend/src/pages/modelRegistry/screens/RegisteredModelsArchive/RegisteredModelArchiveDetails.tsx index 90f1676808..d75bfd17bb 100644 --- a/frontend/src/pages/modelRegistry/screens/RegisteredModelsArchive/RegisteredModelArchiveDetails.tsx +++ b/frontend/src/pages/modelRegistry/screens/RegisteredModelsArchive/RegisteredModelArchiveDetails.tsx @@ -1,6 +1,6 @@ import React from 'react'; import { useNavigate, useParams } from 'react-router'; -import { Button, Flex, FlexItem, Label, Text } from '@patternfly/react-core'; +import { Button, Flex, FlexItem, Label, Text, Truncate } from '@patternfly/react-core'; import ApplicationsPage from '~/pages/ApplicationsPage'; import { ModelRegistrySelectorContext } from '~/concepts/modelRegistry/context/ModelRegistrySelectorContext'; import { registeredModelUrl } from '~/pages/modelRegistry/screens/routeUtils'; @@ -61,7 +61,7 @@ const RegisteredModelsArchiveDetails: React.FC } - description={rm?.description} + description={} loadError={rmLoadError} loaded={rmLoaded} provideChildrenPadding