-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Displaying Image version for OOTB Notebook images in Project View would be useful to have #1917
Comments
UX ContextIs Erwan's expected result what we want? is there anything else we want to add? |
Hi @dpanshug This is my first time to see this issue. I understood why Erwan wanted to add the version info. But in another issue #1520 we added some labels for different statuses. If we add both the status labels and version info, it will get a little crowded. So we should think about these 2 issues together and come up with a solution for them. Does it make sense? |
Hi @erwangranger @dpanshug I am not sure if the version info is important or not. But I think we can hide this piece of info if the version information does not affect the work of the workbench. As shown below, we can make the notebook image is clickable and has a popover to show the version info. This is a common interaction in RHODS UI. What do you think? Thanks! |
I like the flow, only concern is how important is "the current image version" really important to the user. CUDA vs PyTorch is one thing... CUDA 2023.1 vs CUDA 2023.2 is probably not as important at the top level. But I agree the information should be visible. My two cents @xianli123 @erwangranger |
Thanks @andrewballantyne @erwangranger Yes. I was convinced. I think we can just show the version info (with the Recommended text if it is) under the notebook image name as shown below and hide the advanced info in the popover. As far as I know, the admin can disable or delete the whole notebook image instead of a specific version of the notebook image. So if the notebook image is disabled or deleted, we can add a label next to the notebook image name to indicate the status. The interaction will be the same as the issue #1872 fixed. What do you think? Thanks! |
I noticed the screenshot that @erwangranger attached. It's about the notebook image selection. I've seen this UI in another issue(but sorry I forgot which one). But at first I was a little confused about choosing notebook image and version. I am not sure if we change the components from single selection to 2 dropdowns, as shown below. In this way, this part will have the same interaction as the notebook image selection in the workbench creation process. Of course, the previous design, being able to show all the options is a good point. What do you think? @andrewballantyne @erwangranger If it's worth a shot by using 2 dropdowns, I can create a new issue to update the design. |
This is the issue #1690 I mentioned. FYI |
@erwangranger Ok. Let's leave it as it is. What do you think about the solution that I shared? |
Works for me. Thanks @xianli123 . |
I have have assumed the state of the mocks to be complete @xianli123 and moved this to Dev Ready. Let me know if you're intending on spending anymore time on the mocks. I think we have what we need from a development perspective. |
@andrewballantyne Yes. It's ready for dev. |
With the current image streams:
The requirement from UI would be to display this hash on the image selected view on the dashboard. Notebook manifests are already loaded with these information: here
|
Hi guys, JFYI - just created this issue which may be related to this work https://issues.redhat.com/browse/RHOAIENG-348. |
Migrated to the issue noted above. |
Solutions
Review the UX screenshots: #1917 (comment)
Is there an existing issue for this?
Deploy type
Downstream version (eg.
RHODS 1.29
)Version
RHODS 1.32
Current Behavior
Using the pytorch image as an example:
If I create 2 new workbenches using the 2 different versions, it's really hard to tell.
And even unfolding does not help that much:
Expected Behavior
This (highlighted in red) is the info I feel is missing:
Steps To Reproduce
No response
Workaround (if any)
No response
What browsers are you seeing the problem on?
No response
Anything else
No response
The text was updated successfully, but these errors were encountered: