Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Displaying Image version for OOTB Notebook images in Project View would be useful to have #1917

Closed
1 task done
erwangranger opened this issue Oct 5, 2023 · 16 comments
Assignees
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) kind/bug Something isn't working migrated priority/normal An issue with the product; fix when possible

Comments

@erwangranger
Copy link

erwangranger commented Oct 5, 2023

Solutions

Review the UX screenshots: #1917 (comment)

  • Add the version under the image name on the Workbenches table
  • Apply a tooltip for the contents of the version description (same that we show in the Workbench form)

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

Downstream version (eg. RHODS 1.29)

Version

RHODS 1.32

Current Behavior

Using the pytorch image as an example:
image

If I create 2 new workbenches using the 2 different versions, it's really hard to tell.
image

And even unfolding does not help that much:
image

Expected Behavior

This (highlighted in red) is the info I feel is missing:

image

Steps To Reproduce

No response

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Anything else

No response

@erwangranger erwangranger added kind/bug Something isn't working priority/normal An issue with the product; fix when possible untriaged Indicates the newly create issue has not been triaged yet labels Oct 5, 2023
@dpanshug dpanshug removed the untriaged Indicates the newly create issue has not been triaged yet label Oct 11, 2023
@dpanshug dpanshug moved this from Untriaged to UX Backlog in ODH Dashboard Planning Oct 11, 2023
@dpanshug dpanshug added the feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) label Oct 11, 2023
@dpanshug
Copy link
Contributor

UX Context

Is Erwan's expected result what we want? is there anything else we want to add?
cc @xianli123

@xianli123
Copy link

Hi @dpanshug This is my first time to see this issue. I understood why Erwan wanted to add the version info. But in another issue #1520 we added some labels for different statuses. If we add both the status labels and version info, it will get a little crowded. So we should think about these 2 issues together and come up with a solution for them. Does it make sense?

@xianli123
Copy link

xianli123 commented Oct 12, 2023

Hi @erwangranger @dpanshug I am not sure if the version info is important or not. But I think we can hide this piece of info if the version information does not affect the work of the workbench. As shown below, we can make the notebook image is clickable and has a popover to show the version info. This is a common interaction in RHODS UI. What do you think? Thanks!

Screenshot 2023-10-12 at 14 29 28

@andrewballantyne
Copy link
Member

andrewballantyne commented Oct 12, 2023

I like the flow, only concern is how important is "the current image version" really important to the user. CUDA vs PyTorch is one thing... CUDA 2023.1 vs CUDA 2023.2 is probably not as important at the top level. But I agree the information should be visible.

My two cents @xianli123 @erwangranger

@erwangranger
Copy link
Author

Information should be accessible somewhere/somehow. That is the critical piece (80%) for me.
Whether it's better as a popup or inline is of secondary importance to me (20%).

But if I had to make a choice, I'd say that the "deprecated"/"deleted"/"deleted" flags will hopefully not show up too often, and I still think that leaving the screen as it currently is:
image
is misleading to the user.
It really looks like I'm using the same image twice. And it's not until I'll hover over both Pytorch that I'll see it's not the case.
To me, if 2 things are not the same, they should not have the same name. (and this is why I called my workbenches in the screenshot, A and B, so that I could tell them apart easily).

My own opinion (I like knowing which version I'm using) is not necessarily representative of our target users, so UX colleagues, this is your call to make, and I'll be fine either way.

@xianli123
Copy link

xianli123 commented Oct 13, 2023

Thanks @andrewballantyne @erwangranger Yes. I was convinced. I think we can just show the version info (with the Recommended text if it is) under the notebook image name as shown below and hide the advanced info in the popover.

Screenshot 2023-10-13 at 10 51 44

As far as I know, the admin can disable or delete the whole notebook image instead of a specific version of the notebook image. So if the notebook image is disabled or deleted, we can add a label next to the notebook image name to indicate the status. The interaction will be the same as the issue #1872 fixed. What do you think? Thanks!

Screenshot 2023-10-13 at 10 53 53

@xianli123
Copy link

xianli123 commented Oct 13, 2023

I noticed the screenshot that @erwangranger attached. It's about the notebook image selection. I've seen this UI in another issue(but sorry I forgot which one).

image

But at first I was a little confused about choosing notebook image and version. I am not sure if we change the components from single selection to 2 dropdowns, as shown below. In this way, this part will have the same interaction as the notebook image selection in the workbench creation process. Of course, the previous design, being able to show all the options is a good point. What do you think? @andrewballantyne @erwangranger If it's worth a shot by using 2 dropdowns, I can create a new issue to update the design.

Screenshot 2023-10-13 at 14 57 29

@xianli123
Copy link

This is the issue #1690 I mentioned. FYI

@erwangranger
Copy link
Author

Sorry I used a screenshot from the Jupyter Tile. I should not have done that.
It's just that it had a bit more info than the double drop down:
image

I don't think we need to revisit that (^) design for now:

@xianli123
Copy link

@erwangranger Ok. Let's leave it as it is. What do you think about the solution that I shared?

@xianli123 xianli123 moved this from UX Backlog to UX Next in ODH Dashboard Planning Oct 16, 2023
@xianli123 xianli123 self-assigned this Oct 16, 2023
@xianli123 xianli123 moved this from UX Next to UX In Progress in ODH Dashboard Planning Oct 16, 2023
@erwangranger
Copy link
Author

Works for me. Thanks @xianli123 .

@andrewballantyne andrewballantyne moved this from UX In Progress to Dev Ready in ODH Dashboard Planning Oct 19, 2023
@andrewballantyne
Copy link
Member

I have have assumed the state of the mocks to be complete @xianli123 and moved this to Dev Ready. Let me know if you're intending on spending anymore time on the mocks. I think we have what we need from a development perspective.

@xianli123
Copy link

@andrewballantyne Yes. It's ready for dev.

@andrewballantyne andrewballantyne moved this from Dev Ready to Dev To do in ODH Dashboard Planning Nov 9, 2023
@harshad16
Copy link
Member

With the current image streams:

  • The build information would also be provided in the imagestream annotations:
    opendatahub.io/notebook-build-commit: <hash>

The requirement from UI would be to display this hash on the image selected view on the dashboard.
Along with the version info. i,e ex( PyTorch v1.2 e346hu8)
image

Notebook manifests are already loaded with these information: here
Dev Flag for Opendatahub development with this information:

workbenches:
      devFlags:
        manifests:
          - contextDir: components/odh-notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/kubeflow/tarball/v1.7.0-5'
          - contextDir: components/notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/kubeflow/tarball/v1.7.0-5'
          - contextDir: manifests
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/notebooks/tarball/2023b'
      managementState: Managed

@jstourac
Copy link
Member

jstourac commented Dec 6, 2023

Hi guys, JFYI - just created this issue which may be related to this work https://issues.redhat.com/browse/RHOAIENG-348.

@andrewballantyne
Copy link
Member

Migrated to the issue noted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) kind/bug Something isn't working migrated priority/normal An issue with the product; fix when possible
Projects
Status: Done
Status: No status
Archived in project
Development

No branches or pull requests

6 participants