Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story]: Add admin section to control model serving platforms #1913

Closed
lucferbux opened this issue Oct 5, 2023 · 3 comments · Fixed by #1982
Closed

[Story]: Add admin section to control model serving platforms #1913

lucferbux opened this issue Oct 5, 2023 · 3 comments · Fixed by #1982
Assignees
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@lucferbux
Copy link
Contributor

lucferbux commented Oct 5, 2023

Goal

Add a new admin section to enable/disable kserve and model serving

Dependency issue

Itemized goals

  • Add logic to allow users to create projects with kserve (disableKServe: boolean)
  • Add logic to allow users to create projects with modelmesh (disableModelMesh: boolean)
  • Add a new section in cluster settings
  • Add checkbox to enable/disable different platforms
  • Based on [Story]: Add logic to detect if kserve or modelmesh are installed #1946 disable one of the checkbox if the platform is not enabled
  • Add a warning if none of the checkbox are selected

Aspects continued elsewhere

Mocks

@lucferbux lucferbux added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. labels Oct 5, 2023
@lucferbux lucferbux added the feature/model-serving Model Serving Feature label Oct 5, 2023
@lucferbux lucferbux moved this from Untriaged to Dev To do in ODH Dashboard Planning Oct 5, 2023
@lucferbux
Copy link
Contributor Author

@vconzola I think there were some issues up in the air for the admin section right?

@vconzola
Copy link

@lucferbux I think there were, but based on our conversation earlier today, are we good? I'll update the mocks to match what we talked about.

@lucferbux
Copy link
Contributor Author

@lucferbux I think there were, but based on our conversation earlier today, are we good? I'll update the mocks to match what we talked about.

@vconzola I'm only missing one more thing, are we gonna disable an option if we detect the platform is not enabled in the cluster? Meaning that if kserve is not installed, I assume we would want to greyed out that to the user right? Or we let that until it fails in the project creation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants