Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Terminology for Pipeline Logs #1736

Closed
andrewballantyne opened this issue Sep 1, 2023 · 6 comments · Fixed by #2005
Closed

[Feature Request]: Terminology for Pipeline Logs #1736

andrewballantyne opened this issue Sep 1, 2023 · 6 comments · Fixed by #2005
Assignees
Labels
feature/ds-pipelines Data Science Pipelines feature (aka DSP) kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible

Comments

@andrewballantyne
Copy link
Member

Feature description

Follow up on #1247

Containers is our UI focus right now.
Steps is Tekton's run state.

Should we look to talk more about steps and less about pure log containers. We may want to look at improving log-based naming? We talk about pods in errors because K8s talks about it. We could look to try and not show errors flat footed -- but it may be difficult.

Describe alternatives you've considered

No response

Anything else?

No response

@andrewballantyne andrewballantyne added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible needs-ux labels Sep 1, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Sep 1, 2023
@andrewballantyne
Copy link
Member Author

cc @yih-wang

@manaswinidas manaswinidas added feature/ds-pipelines Data Science Pipelines feature (aka DSP) and removed untriaged Indicates the newly create issue has not been triaged yet labels Sep 6, 2023
@manaswinidas manaswinidas moved this from Needs prioritization to To do in ODH Dashboard Planning Sep 6, 2023
@andrewballantyne andrewballantyne moved this from Dev To do to UX Backlog in ODH Dashboard Planning Sep 15, 2023
@andrewballantyne
Copy link
Member Author

Let us change anywhere Containers is display in the Pipeline Logs view and turn it to Steps.

cc @yih-wang

@andrewballantyne andrewballantyne moved this from UX Backlog to Dev To do in ODH Dashboard Planning Oct 11, 2023
@yih-wang
Copy link

@andrewballantyne When I updated the terminology for the group title within the Step dropdown, this question occurred to me - is it true that we decided not to show the init containers in the Containers (currently named Steps) dropdown?

@andrewballantyne
Copy link
Member Author

Yeah, unless you know of a value add to show init containers, I see no reason to add them. @yih-wang These are Pipeline Logs, not Pod investigation screens... I think we should probably stick to the singular goal. If we want more pod information, perhaps we rollout another tab for that.

@yih-wang
Copy link

yih-wang commented Oct 13, 2023

Thanks for the clarification @andrewballantyne. That makes sense. I just updated the dropdown example inside the Step dropdown to align with the decision.

I've made the change from 'Containers' to 'Steps' in the final design link (the one provided in #1247 ). Is there a specific place where I should note this change apart from the design itself?

@andrewballantyne
Copy link
Member Author

Thanks for the clarification @andrewballantyne. That makes sense. I just updated the dropdown example inside the Step dropdown to align with the decision.

I've made the change from 'Containers' to 'Steps' in the final design link (the one provided in #1247 ). Is there a specific place where I should note this change apart from the design itself?

@yih-wang here will be fine. We can use this ticket to adjust the text.

@manaswinidas manaswinidas moved this from Dev To do to Dev In progress in ODH Dashboard Planning Oct 23, 2023
@manaswinidas manaswinidas self-assigned this Oct 23, 2023
@manaswinidas manaswinidas linked a pull request Oct 23, 2023 that will close this issue
7 tasks
@manaswinidas manaswinidas removed a link to a pull request Oct 23, 2023
7 tasks
@manaswinidas manaswinidas linked a pull request Oct 23, 2023 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from Dev In progress to Done in ODH Dashboard Planning Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ds-pipelines Data Science Pipelines feature (aka DSP) kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants