From d4f17fd65af7945be56579907aa5944262cbd58a Mon Sep 17 00:00:00 2001 From: pnaik1 Date: Wed, 10 Jul 2024 16:32:42 +0530 Subject: [PATCH] changed the filters to Created after --- .../cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts | 4 ++-- .../pipelines/content/compareRuns/CompareRunTableToolbar.tsx | 2 +- .../content/tables/experiment/ExperimentTableToolbar.tsx | 2 +- .../content/tables/pipelineRun/PipelineRunTableToolbar.tsx | 2 +- .../global/experiments/compareRuns/ManageRunsTable.tsx | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts index d98b1a09de..8b3398d583 100644 --- a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts +++ b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts @@ -434,7 +434,7 @@ describe('Pipeline runs', () => { activeRunsTable.getRowByName('Test active run 3').find().should('exist'); }); - it('filter by started', () => { + it('filter by created after', () => { pipelineRunsGlobal.visit(projectName, pipelineId, pipelineVersionId, 'active'); // Verify initial run rows exist @@ -443,7 +443,7 @@ describe('Pipeline runs', () => { // Select the "Started" filter, select a value to filter by pipelineRunsGlobal .findActiveRunsToolbar() - .within(() => pipelineRunsGlobal.selectFilterByName('Started')); + .within(() => pipelineRunsGlobal.selectFilterByName('Created after')); // Mock runs (filtered by start date), type a start date activeRunsTable.mockGetActiveRuns( diff --git a/frontend/src/concepts/pipelines/content/compareRuns/CompareRunTableToolbar.tsx b/frontend/src/concepts/pipelines/content/compareRuns/CompareRunTableToolbar.tsx index fa617c215a..a8ba7c1c41 100644 --- a/frontend/src/concepts/pipelines/content/compareRuns/CompareRunTableToolbar.tsx +++ b/frontend/src/concepts/pipelines/content/compareRuns/CompareRunTableToolbar.tsx @@ -31,7 +31,7 @@ const CompareRunTableToolbar: React.FC = ({ ...toolbarProps }) => { [FilterOptions.NAME]: 'Run', [FilterOptions.EXPERIMENT]: 'Experiment', [FilterOptions.PIPELINE_VERSION]: 'Pipeline version', - [FilterOptions.CREATED_AT]: 'Started', + [FilterOptions.CREATED_AT]: 'Created after', [FilterOptions.STATUS]: 'Status', }), [], diff --git a/frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableToolbar.tsx b/frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableToolbar.tsx index cd79781ea8..4e1cea62fa 100644 --- a/frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableToolbar.tsx +++ b/frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableToolbar.tsx @@ -8,7 +8,7 @@ import CreateExperimentButton from '~/concepts/pipelines/content/experiment/Crea const options = { [FilterOptions.NAME]: 'Experiment', - [FilterOptions.CREATED_AT]: 'Created', + [FilterOptions.CREATED_AT]: 'Created after', }; export type FilterProps = Pick< diff --git a/frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableToolbar.tsx b/frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableToolbar.tsx index 4741c71890..690235b0f2 100644 --- a/frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableToolbar.tsx +++ b/frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableToolbar.tsx @@ -42,7 +42,7 @@ const PipelineRunTableToolbar: React.FC = ({ ...(!pipelineVersionId && { [FilterOptions.PIPELINE_VERSION]: 'Pipeline version', }), - [FilterOptions.CREATED_AT]: 'Started', + [FilterOptions.CREATED_AT]: 'Created after', [FilterOptions.STATUS]: 'Status', }), [experimentId, isExperimentsAvailable, pipelineVersionId], diff --git a/frontend/src/pages/pipelines/global/experiments/compareRuns/ManageRunsTable.tsx b/frontend/src/pages/pipelines/global/experiments/compareRuns/ManageRunsTable.tsx index 23f07c791e..409d6cada6 100644 --- a/frontend/src/pages/pipelines/global/experiments/compareRuns/ManageRunsTable.tsx +++ b/frontend/src/pages/pipelines/global/experiments/compareRuns/ManageRunsTable.tsx @@ -94,7 +94,7 @@ export const ManageRunsTable: React.FC = ({ [FilterOptions.NAME]: 'Run', [FilterOptions.EXPERIMENT]: 'Experiment', [FilterOptions.PIPELINE_VERSION]: 'Pipeline version', - [FilterOptions.CREATED_AT]: 'Started', + [FilterOptions.CREATED_AT]: 'Created after', [FilterOptions.STATUS]: 'Status', }} {...filterProps}