Don't leave dangling refs when removing more than 350 constraints (#272)

* set problem to none * add RNs * Update CHANGELOG.rst Co-authored-by: Moritz E. Beber <[email protected]> * implement review comments --------- Co-authored-by: Moritz E. Beber <[email protected]>
opencobra · Nov 26, 2024 · 8e49484 · 8e49484
1 parent 5cbc2c1
commit 8e49484
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -7,6 +7,8 @@ Next Release
 -----
 * fix the objective offset test for compatibility with Debian sid
 * enable compatibility with Gurobi 12.0
+* fix an issue where the removal of more than 350 constraints
+  would lead to dangling references
 
 1.8.2
 -----

diff --git a/src/optlang/interface.py b/src/optlang/interface.py
@@ -1577,6 +1577,8 @@ def _remove_constraints(self, constraints):
         keys = [constraint.name for constraint in constraints]
         if len(constraints) > 350:  # Need to figure out a good threshold here
             self._constraints = self._constraints.fromkeys(set(self._constraints.keys()).difference(set(keys)))
+            for co in constraints:
+                co.problem = None
         else:
             for constraint in constraints:
                 try: