Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise and improve authentication #282

Open
pdeenen opened this issue Oct 22, 2024 · 1 comment
Open

Revise and improve authentication #282

pdeenen opened this issue Oct 22, 2024 · 1 comment
Labels
Bug A bug
Milestone

Comments

@pdeenen
Copy link
Contributor

pdeenen commented Oct 22, 2024

No description provided.

@pdeenen pdeenen added the Bug A bug label Oct 22, 2024
@pdeenen pdeenen added this to the 4.0.0 milestone Oct 22, 2024
@klafbang
Copy link
Collaborator

Auth right now does not properly prevent access.

Authentication has a flow that redirects to the auth server, and returns with a code that has to be exchanged for a token. The Role Guard assumes the existence of a token, meaning it is not possible to redirect to a protected page as it cannot exchange the code for a token before access is denied.

Longer tern, auth should probably rely on Cerbos or similar, and use a more sophisticated authentication service.

For the shorter term, I propose making login required for all pages and removing the role guard. That way pages are protected, we eliminate the in-between page with a forced manual login, and the code -> token exchange is possible.

This makes it a straightforward change to later introduce more flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants