Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview Loaed Popups Prevent Invalid pages.json Error Popup to Display to User #85

Open
2 tasks done
aematei opened this issue Jun 10, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@aematei
Copy link
Collaborator

aematei commented Jun 10, 2024

Checklist before submitting a bug report

  • I have reviewed CONTRIBUTING.md document
  • I have done a quick search on the issue tracker to check if the bug report is not redundant

Context

When testing feat/74-json-schemas #84, I noticed that the error popup that was expected to display when I removed line 3 of src/vision/viewpoints/pages.json does not display due to being crowded out by other notifications.

Steps to reproduce the bug

  1. Open this repo in OML Vision https://github.com/UTNAK/kepler16b-using-imce-vocabulary
  2. Click on the eye icon to activate OML Vision
  3. Go into src/vision/viewpoints/pages.json
  4. Remove line 3
  5. Save the file
  6. You should see a popup or in the console saying Invalid or missing pages.json.
  7. Undo deleting line 3
  8. Save the file
  9. You should see a popup or in the console saying pages.json loaded successfully.

Current result

image

Expected result

A notification popup should indicate that the pages.json file is invalid or missing.

Additional context

Possible fix

Either combine pertinent notifications to prevent this, or change VSCode's default behavior, which is to only display 3 notifications at one time.

Technical data

  • Operating system: macos 13.6.1 (22G313)
  • Version of the repo: feat/74-json-schemas commit:ffb975710c6f2b2338425633daf0fb6bd1f38868
  • VSCode version: 1.89.1
@aematei aematei added the bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant