Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading Viewpoints when saving any viewpoints definition defined in the viewpoints directory #46

Open
2 tasks done
pogi7 opened this issue Mar 27, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@pogi7
Copy link
Member

pogi7 commented Mar 27, 2024

Checklist before submitting a bug report

  • I have reviewed CONTRIBUTING.md document
  • I have done a quick search on the issue tracker to check if the bug report is not redundant

Context

I want to be able to load new viewpoints when saving any viewpoint definition that is defined in the viewpoints file of a OML model like https://github.com/pogi7/kepler16b-example

Steps to reproduce the bug

  1. Go into the any OML model like https://github.com/pogi7/kepler16b-example
  2. Change the line to in this file to
"label": "Test",
  1. Save the file
  2. Verify that the new change does not appear in the Property Sheet

Current result

The new viewpoint is not rendered when saving the viewpoint definition file.

Expected result

The new viewpoint should render when saving the viewpoint definition file.

Additional context

[Any additional context. If applicable, you may provide screenshots and/or error logs.]

Possible fix

The bug is in controller/src/utilities/loaders/loadViewpointFiles.ts in the method

TreeDataProvider.getInstance().updateViewpoints(content);

that method should be called in the following methods

loadTableFiles
loadTreeFiles
loadDiagramFiles
loadPropertyFiles

Technical data

  • Operating system: Darwin localhost 22.6.0 Darwin Kernel Version 22.6.0: Sun Dec 17 22:12:45 PST 2023; root:xnu-8796.141.3.703.2~2/RELEASE_ARM64_T6000 arm64
  • Version of the repo: 534c0ee
  • VSCode version: 1.87.0
@pogi7 pogi7 added the bug Something isn't working label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant