-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change byte order of base MAC in the SoftAP SSID. #316
base: main
Are you sure you want to change the base?
Conversation
Build failure reason is
|
Thanks for this PR! Since it will change the SSID of the OBS that are currently in use, we should have some text prepared for the release notes. Consider that the users don`t (need to) know what a mac is but they might need to update the connection to the OBS via the mobile if this is used. |
this is because your branch build does not have access to the SonarQube credentials. This is a needed security measure, but we might skip the SonarQube analysis in this case. |
Valid point. I did not considered this impact.
Maybe we could use the |
This means we would step always into this problem, when someone raise a PR from a fork? Would it be possible to run the SonarQube analysis on a branch based on the PR instead on the downstream branch? as draft (non complete list of commands, only to describe the principle)
|
IHMO this is because if you can modify the build workflow you might gain access to the otherwise secret data. I've created #317 for this. |
I wonder how we can get valid feedback. Otherwise, since we expect not to bad impact, we can just change it and see if we get negative feedback.
If it is not to long, it is well shown in the display once the access point is started. |
Should we do this together with #141 to get a consistent solution? |
With this PR the computed SSID for the ConfigServer access point contains the hexadecimal digits in the same order as they are reported for the base MAC.
reported MAC
SSID of the access point
The MAC of the SoftAP (BSSID) is different to the base MAC id. An explanation can be found at
https://espressif-docs.readthedocs-hosted.com/projects/esp-idf/en/stable/api-reference/system/system.html#mac-address
This fixes #315.