Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making an affiliation matching tests logging outcome on TRACE level visible in console #1493

Open
marekhorst opened this issue Nov 18, 2024 · 2 comments

Comments

@marekhorst
Copy link
Member

Currently the information generated by the AffOrgMatchVoterStrengthEstimatorAndTest is logged on the TRACE level which is not being logged by default. This makes working on reestimation of the voters' strength rather difficult and having this logged during running the tests would be rather beneficial.

The file already created to cover quite specific logging requirements of the affiliation matching module:

iis-wf/iis-wf-affmatching/src/test/resources/log4j.properties

currently does not enable AffOrgMatchVoterStrengthEstimatorAndTest class to log the information on the TRACE level.

@marekhorst
Copy link
Member Author

marekhorst commented Nov 18, 2024

Adding the following line:

log4j.logger.eu.dnetlib.iis.wf.affmatching.match.voter=TRACE

in the iis-wf/iis-wf-affmatching/src/test/resources/log4j.properties file will solve that issue.

It will be solved assuming the .classpath file created for Eclipse environment within the iis-wf-affmatching module has this location defined prior to the location of the default iis-common/src/main/resources/log4j.properties file which is meant to be used in a production cluster environment. The order of loading log4j.properties files determines which log4j configuration will be taken into account.

@marekhorst
Copy link
Member Author

marekhorst commented Nov 18, 2024

I proved this to be working in a local environment it just needs to be decided if it should be a default configuration. One obvious drawback is having test logs polluted with this additional information which is not very useful when running an automated tests suite.

@marekhorst marekhorst changed the title Consider making an affiliation matching tests logging outcome logged on TRACE level visible in console Consider making an affiliation matching tests logging outcome on TRACE level visible in console Nov 18, 2024
marekhorst added a commit that referenced this issue Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant