Make output archives more reproducible #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit stores the mtime of the go.mod file as the mtime for all files in the produced archive. It also remove the optional timestamp in gz archive. This is enought to get reproducible output for tar.gz, tar.xz and tar.zstd. Signed-off-by: Nicolas Belouin <[email protected]>
|
Thanks for this @diconico07! It is really helpful for us. |
|
Yes, thanks for the contribution, accepting. |
|
@jfkw Could we have a new release with this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit stores the mtime of the go.mod file as the mtime for all files in the produced archive.
It also remove the optional timestamp in gz archive.
This is enought to get reproducible output for tar.gz, tar.xz and tar.zstd.
For
obscpiofiles, it will not be possible to get reproducible output without some modifications to libarchive or not using libarchive for cpio output, so didn't do anything for this file format right now