Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of MinimumSamplingInterval attribute is missing #245

Open
matkonnerth opened this issue Nov 28, 2023 · 6 comments
Open

Parsing of MinimumSamplingInterval attribute is missing #245

matkonnerth opened this issue Nov 28, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@matkonnerth
Copy link
Collaborator

matkonnerth commented Nov 28, 2023

Nodeset schema defines a MinimumSamplingInterval attribute for UAVariable

@matkonnerth matkonnerth added the good first issue Good for newcomers label Dec 8, 2023
@matkonnerth matkonnerth changed the title support for MinimumSamplingInterval missing Parsing of MinimumSamplingInterval attribute is missing Dec 8, 2023
@piperoc
Copy link
Contributor

piperoc commented Mar 23, 2024

I added and tested the MinimumSamplingAttribute for UAVariable.

You can check my modifications in my fork piperoc/open62541-nodeset-loader . Look for the branch add-minSamplingInterval .

not sure you wanted me to use PR's or so, therefore I figured I'd fork it.

Please double check: I tested with a few nodesets. Some nodesets give me troubles in general (for example, the euromap ones are weird for me).

@matkonnerth
Copy link
Collaborator Author

thank you, I've create a PR from your work.

Which euromap nodesets generate troubles?

@matkonnerth
Copy link
Collaborator Author

looks good, merged it to master.

@piperoc
Copy link
Contributor

piperoc commented Mar 26, 2024

thank you, I've create a PR from your work.

Which euromap nodesets generate troubles?

Thank you @matkonnerth . I haven't tested extensively, but here's an error I get all the time with the following:

image

Could it be due to the UAModeler extensions?

@matkonnerth
Copy link
Collaborator Author

seems that there is a circle with hierachical references between some nodes (node1 -> node2 ->node1), can you provide me the nodeset?

@piperoc
Copy link
Contributor

piperoc commented Mar 26, 2024

Sure @matkonnerth, the nodeset I used is the one in open62541-nodeset-loader/nodesets/euromap_instances/euromapinstances.xml .

I think UANodesets may contain loops (as a directed multigraph)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants