Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring random unicode characters in .json files. #246

Closed
augustjohnson opened this issue May 19, 2023 · 1 comment · Fixed by #559
Closed

Recurring random unicode characters in .json files. #246

augustjohnson opened this issue May 19, 2023 · 1 comment · Fixed by #559
Assignees

Comments

@augustjohnson
Copy link
Collaborator

Our json files occasionally get edited by stuff like pythons open() which sometimes results in weird character stuff.

Example of errant unicode showing up unwanted.
6118e17

This is sometimes invisible to people editing the files (because of their editors and stuff).

Potential solutions:

  • Tests (literally pytest tests) that check the files for a set of commonly messed up characters and fail if they show up.
  • Pre-commit checks for unicode or something, I'm not sure exactly the specific scenario.
  • Documentation on how to interact with the json files using python files plus maybe some examples?
@augustjohnson
Copy link
Collaborator Author

Definition of Done:

  • Check all files in the /data directory for various unicode characters that are whitespace, etc. - Fix
  • Check them also for backticks instead of single ticks. - Fix
  • Write a script in /scripts that does this, and fails.
  • Add that script onto the build.

@augustjohnson augustjohnson self-assigned this Oct 6, 2024
@augustjohnson augustjohnson linked a pull request Oct 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant