Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on OTEL_SDK_DISABLED #1667

Closed
kaylareopelle opened this issue Dec 10, 2024 · 1 comment
Closed

Clarification on OTEL_SDK_DISABLED #1667

kaylareopelle opened this issue Dec 10, 2024 · 1 comment

Comments

@kaylareopelle
Copy link
Contributor

The spec for OTEL_SDK_DISABLED is a little vague to me. Can someone help clarify the scope?

Here's the description:

Boolean value. If “true”, a no-op SDK implementation will be used for all telemetry signals. Any other value or absence of the variable will have no effect and the SDK will remain enabled. This setting has no effect on propagators configured through the OTEL_PROPAGATORS variable.

This came up because Ruby received a PR to implement this environment variable, but we're not sure how far the functionality needs to go. The PR as it stands would skip creating providers through configuration, but someone could still manually create functional providers and tracers/meters/loggers. Is that acceptable?

I took a look at open-telemetry/opentelemetry-python#3648, and it seems like they always return no-ops when OTEL_SDK_DISABLED is true.

However, Java's implementation seems closer to the Ruby PR. Configuration is skipped, but I don't know enough about Java to know if that means you cannot create working tracers, etc.

@kaylareopelle
Copy link
Contributor Author

Whoops, wrong repo... closing and will reopen in the specification repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant