Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process.open_file_descriptor.count and process.context_switches both have unexpected unit {count} #1662

Open
trask opened this issue Dec 9, 2024 · 2 comments
Open

process.open_file_descriptor.count and process.context_switches both have unexpected unit {count} #1662

trask opened this issue Dec 9, 2024 · 2 comments
Labels
area:process bug Something isn't working system-semconv-wg-ga-blocker triage:needs-triage

Comments

@trask
Copy link
Member

trask commented Dec 9, 2024

Area(s)

area:process

What happened?

process.open_file_descriptor.count and process.context_switches both have unexpected unit {count}.

Probably should be something like {open_file_descriptor} and {context_switch}?

Semantic convention version

v1.29.0

Additional context

No response
@trask trask added bug Something isn't working triage:needs-triage labels Dec 9, 2024
@trask
Copy link
Member Author

trask commented Dec 9, 2024

cc @open-telemetry/semconv-system-approvers

@trask trask mentioned this issue Dec 9, 2024
Open
@mx-psi
Copy link
Member

mx-psi commented Dec 12, 2024

Discussed on the meeting on 2024-12-12, the name of these metrics was changed on /pull/330 and we agree the units should have been changed as well

@mx-psi mx-psi moved this from Todo to Decision made in System Semantic Convention Working Group Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:process bug Something isn't working system-semconv-wg-ga-blocker triage:needs-triage
Projects
System Semantic Convention Working Group
Status: Decision made
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trask @mx-psi