Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent values used for rpc.system by aws-sdk spans #1545

Open
Flarna opened this issue Nov 4, 2024 · 0 comments · May be fixed by #1622
Open

Inconsistent values used for rpc.system by aws-sdk spans #1545

Flarna opened this issue Nov 4, 2024 · 0 comments · May be fixed by #1622
Labels
area:aws area:rpc bug Something isn't working triage:needs-triage

Comments

@Flarna
Copy link
Member

Flarna commented Nov 4, 2024

Area(s)

area:aws, area:rpc

What happened?

Description

AWS SDK spans tell the value to use for rpc.system is aws-api (see here)

rpc.system does not contain this value (see here).

Even worse the generated md file holds a table for the well known rpc.system values which adds more confusion.

Steps to Reproduce (if any)

Expected Result

Consistent specification which values to use for rpc.system in case of AWS SDK.

Actual Result

Semantic convention version

v1.28.0

Additional context

No response
@Flarna Flarna added bug Something isn't working triage:needs-triage labels Nov 4, 2024
@Flarna Flarna linked a pull request Nov 27, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:aws area:rpc bug Something isn't working triage:needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc: add aws_api to well known rpc.system values Flarna/semantic-conventions
1 participant
@Flarna