Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that db.response.result_rows should be captured even on operations which do not return rows? #1522

Open
trask opened this issue Oct 28, 2024 · 0 comments
Open

Clarify that db.response.result_rows should be captured even on operations which do not return rows? #1522

trask opened this issue Oct 28, 2024 · 0 comments
Labels
area:db

Comments

@trask
Copy link
Member

trask commented Oct 28, 2024

This would help with differentiating between these two cases:

  • no rows were returned
  • the instrumentation doesn't support capturing this attribute

Related: currently the Cosmos semantic conventions says that db.response.result_rows is

conditionally_required: if response was received and returned any rows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:db
Projects
Database Client Semantic Conventions
Status: Post Stability
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trask