Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system metrics reporting total memory capacity or clarify how to recover existing ones #127

Open
2 of 4 tasks
mx-psi opened this issue Jun 22, 2023 · 7 comments · Fixed by #1356
Open
2 of 4 tasks
Assignees

Comments

@mx-psi
Copy link
Member

mx-psi commented Jun 22, 2023

Current system metrics cover usage of memory, paging/swap memory and filesystems, but we don't currently support the total capacity of any of these systems as a separate metric.

The following metric can't be recovered from the existing system metrics and would need to be added to support this:

Name Description Units Instrument Type Value Type Attribute Key Attribute Values
system.disk.limit Total memory available in the disk. By UpDownCounter Int64 device (identifier)

The following metric may be recovered from system.memory.usage, but the current description of the attribute values of state is insufficient to recover this.

Name Description Units Instrument Type Value Type Attribute Key Attribute Values
system.memory.limit Total memory available in the machine. Does not include paging/swap memory. By UpDownCounter Int64 n/a n/a

The following metrics are available as the sum of used and free (and reserved for the file system one). They could be added as a convenience metric:

Name Description Units Instrument Type Value Type Attribute Key Attribute Values
system.filesystem.limit Total memory available in the disk. By UpDownCounter Int64 device (identifier)
state used, free, reserved
type ext4, tmpfs, etc.
mode rw, ro, etc.
mountpoint (path)
system.paging.limit Total paging/swap memory available. By UpDownCounter Int64 n/a n/a

Items for this issue:

This would be part of open-telemetry/opentelemetry-specification/issues/3556 if approved.

@mx-psi
Copy link
Member Author

mx-psi commented Aug 14, 2023

Thanks, I changed all .total suffixes by .limit suffixes above :)

@yevgentrukhin
Copy link

yevgentrukhin commented Sep 7, 2023

Curious for next steps, will there be a PR for this change to semantic convention?

@mx-psi
Copy link
Member Author

mx-psi commented Sep 8, 2023

Curious for next steps, will there be a PR for this change to semantic convention?

@yevgentrukhin yes, this is part of the system semantic conventions WG roadmap and will be addressed before stabilization of system metrics. If you are interested in having this sooner, I am happy to review PRs related to this and you can join our weekly meeting to discuss if necessary (see here for details)

@mx-psi mx-psi mentioned this issue Sep 26, 2023
3 tasks
@mx-psi
Copy link
Member Author

mx-psi commented Sep 26, 2023

Clarify set of attribute values for system.memory.usage state and consider using system.memory.total

I have marked this one as done, since #89 we have the the total value for state which would be system.memory.limit

@mx-psi
Copy link
Member Author

mx-psi commented Jan 18, 2024

Discussed on January 18th System Semantic Conventions WG meeting, we don't consider this one to be a blocker for system metrics GA unless the new metrics affect existing metrics. @mx-psi to double check this.

@rogercoll
Copy link
Contributor

rogercoll commented Sep 2, 2024

@joaopgrassi Sorry, I think in the #1356 PR I did not specify that it was partially solving this issue. I reckon system.filesystem.limit and system.paging.limit metrics still need to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants