Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] translate OpenTelemetry primer #4694

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

ymotongpoo
Copy link
Contributor

@ymotongpoo ymotongpoo commented Jun 17, 2024

translate the following files

  • content/ja/docs/concepts/_index.md
  • content/ja/docs/concepts/observability-primer.md

@ymotongpoo ymotongpoo force-pushed the ja/concepts/primer branch from 9486428 to 12ace3f Compare June 18, 2024 08:44
@ymotongpoo ymotongpoo force-pushed the ja/concepts/primer branch from 64e60c2 to fcd7bdc Compare June 18, 2024 13:14
@ymotongpoo ymotongpoo marked this pull request as ready for review June 18, 2024 15:42
@ymotongpoo ymotongpoo requested a review from a team June 18, 2024 15:42
@ymotongpoo ymotongpoo force-pushed the ja/concepts/primer branch from cf9c15d to 191bfe5 Compare June 18, 2024 15:42
@svrnm svrnm requested a review from a team June 18, 2024 18:37
@svrnm
Copy link
Member

svrnm commented Jun 18, 2024

requested review from @open-telemetry/docs-ja-approvers. We still need to update the code owners file for that

@ymotongpoo ymotongpoo force-pushed the ja/concepts/primer branch from 191bfe5 to 8671d24 Compare June 18, 2024 23:20
@ymotongpoo ymotongpoo requested a review from a team June 18, 2024 23:20
Copy link
Contributor

@katzchang katzchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment was made on the Japanese wording. Other than that, no problems.

content/ja/docs/concepts/observability-primer.md Outdated Show resolved Hide resolved
@ymotongpoo ymotongpoo force-pushed the ja/concepts/primer branch 2 times, most recently from 465e7d4 to 9a81d3f Compare June 21, 2024 01:14
@ymotongpoo
Copy link
Contributor Author

@open-telemetry/docs-approvers This PR got approval from @open-telemetry/docs-ja-approvers so can anyone move this forward? Thanks!

@svrnm svrnm requested a review from katzchang June 21, 2024 09:20
@svrnm
Copy link
Member

svrnm commented Jun 21, 2024

@open-telemetry/docs-approvers This PR got approval from @open-telemetry/docs-ja-approvers so can anyone move this forward? Thanks!

Thanks for tagging @ymotongpoo, @katzchang needs to re-review and click on "approve" if no other changes are required

@svrnm svrnm force-pushed the ja/concepts/primer branch from 9a81d3f to 716bd39 Compare June 21, 2024 13:32
@svrnm
Copy link
Member

svrnm commented Jun 21, 2024

Not sure why the text linter reports failure, those are files unrelated to this PR

@svrnm svrnm force-pushed the ja/concepts/primer branch from 716bd39 to 99a99ce Compare June 21, 2024 14:13
@svrnm svrnm merged commit a47ab10 into open-telemetry:main Jun 21, 2024
16 checks passed
@svrnm
Copy link
Member

svrnm commented Jun 21, 2024

thank you @ymotongpoo and @katzchang

@ymotongpoo ymotongpoo deleted the ja/concepts/primer branch June 24, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants