Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt-br] Localize index page to Portuguese (Brazil) #4615

Closed
wants to merge 16 commits into from
Closed

[pt-br] Localize index page to Portuguese (Brazil) #4615

wants to merge 16 commits into from

Conversation

edsoncelio
Copy link
Member

@edsoncelio edsoncelio commented Jun 6, 2024 •
edited
Loading

Changes

  • Created /content/pt-br/_index.md
  • Added the language config to hugo.yaml

Preview

https://deploy-preview-4615--opentelemetry.netlify.app/pt

cc @jpkrohling

@edsoncelio edsoncelio requested a review from a team June 6, 2024 23:48
@edsoncelio edsoncelio force-pushed the feature/ptbr_version branch from a169a1c to cd4c99e Compare June 6, 2024 23:48
@knabben
Copy link

knabben commented Jun 6, 2024

/lgtm

@edsoncelio
Copy link
Member Author

cc @igorestevanjasinski

jpkrohling
jpkrohling reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great start, thank you @edsoncelio!

content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
hugo.yaml Show resolved Hide resolved
@svrnm
Copy link
Member

svrnm commented Jun 7, 2024

Thank you @edsoncelio and @jpkrohling, looking forward to have a third language in place! :-)

@chalin: please take a look

@edsoncelio edsoncelio force-pushed the feature/ptbr_version branch from 9e696c6 to 90a7070 Compare June 7, 2024 10:44
@chalin chalin force-pushed the feature/ptbr_version branch from 09c5b9f to 6e0c446 Compare June 7, 2024 12:56
@edsoncelio
Copy link
Member Author

@chalin please could you give a helping hand to fix this spelling check error?
I'm not sure If I need to create a new spelling check file with the pt-br words or something similar.

@chalin
Copy link
Contributor

chalin commented Jun 7, 2024

Hi @edsoncelio - yes, I'll jump in to help as soon as I can. FYI, note my comment in the #otel-docs-localization Slack: https://cloud-native.slack.com/archives/C076RUAGP37/p1717767428381689:

All: as was discussed during the last Comms meeting, onboarding of new languages will be incremental and slightly throttled back. I’m still trying to ensure that we have the necessary base infrastructure and docs to support new localizations. My focus will be on the support of localizations that have already landed so as to avoid overwhelm and unnecessary churn. This is just a heads up, and is not meant to curb anyone’s enthusiasm! 😄 So if you submit a new localization, and we don’t get to merging it right away, this is why. Cheerio! ✨

@edsoncelio
Copy link
Member Author

Hi @edsoncelio - yes, I'll jump in to help as soon as I can. FYI, note my comment in the #otel-docs-localization Slack: https://cloud-native.slack.com/archives/C076RUAGP37/p1717767428381689:

All: as was discussed during the last Comms meeting, onboarding of new languages will be incremental and slightly throttled back. I’m still trying to ensure that we have the necessary base infrastructure and docs to support new localizations. My focus will be on the support of localizations that have already landed so as to avoid overwhelm and unnecessary churn. This is just a heads up, and is not meant to curb anyone’s enthusiasm! 😄 So if you submit a new localization, and we don’t get to merging it right away, this is why. Cheerio! ✨

I saw it now!
Thanks, no worries!

chalin
chalin reviewed Jun 8, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address inline comment, then rebase from main (after pulling in the latest), and resubmit.

content/pt-br/_index.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, rename the folder to content/pt.

@chalin chalin marked this pull request as draft June 8, 2024 12:27
@chalin chalin marked this pull request as ready for review June 9, 2024 01:14
@chalin chalin marked this pull request as draft June 9, 2024 01:15
@chalin
Copy link
Contributor

chalin commented Jul 4, 2024

Please rebase, as I can't from the UI:

image

@edsoncelio
Copy link
Member Author

Please rebase, as I can't from the UI:

image

Sure!

@edsoncelio edsoncelio mentioned this pull request Jul 4, 2024
Merged
@edsoncelio
Copy link
Member Author

@chalin I opened a new PR with the latest changes, I had a lot of conflicts to fix when rebasing.
We can close this one!
#4794

@chalin
Copy link
Contributor

chalin commented Jul 5, 2024

Superseded by #4794. Closing

@chalin chalin closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorestevanjasinski igorestevanjasinski igorestevanjasinski left review comments

@EzzioMoreira EzzioMoreira EzzioMoreira left review comments

@chalin chalin chalin left review comments

@reisfrancislei reisfrancislei reisfrancislei left review comments

@jpkrohling jpkrohling jpkrohling left review comments

Assignees

@chalin chalin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@edsoncelio @knabben @svrnm @chalin @jpkrohling @reisfrancislei @EzzioMoreira @igorestevanjasinski