You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I second @windsonsea comment, this should be removed in the spirit of keeping things DRY. Otherwise, how do you know that the comment is up-to-date? You'll need to open the original file to double check anyways.
Please remove all embedded HTML comments.
What would be more useful would be to include, in the front matter, a permalink to the specific version (including the commit hash) of the en page that was used to create this translation, but we can discuss this separately. /cc @open-telemetry/docs-approvers
Being able to detect page drift between en and non-en pages is a challenging problem. @cjyabraham has made me aware of solutions used by other CNCF projects. I'll be reviewing those a reporting back here.
In #4536 (comment), @my-git9 proposes to use the K8s zh localization approach of embedding en page segments in zh pages as HTML comments. I'd strongly vote against this approach because:
The duplication and maintenance overhead of keeping those en language HTML comments up-to-date.
Embedding en page segments as HTML only compounds the maintenance problem without helping us detect if there is a drift between en and zh pages.
I'll be reviewing other CNCF-project approaches to this and report back here as soon as I can.
@open-telemetry/docs-maintainers - FYI, during today's Comms meeting we agreed to not / no longer merge non-en language pages containing embedded en-source page fragments as HTML comments. @svrnm - I assume that you'll follow up with the zh PRs that you merged before the meeting to ask them to strip the comments? Thanks!
I'm satsified with the proposed design and implementation, as documented in https://opentelemetry.io/docs/contributing/localization/. We'll continue to vet the approach and adjust as needed, but I'm closing-as-completed for now.
Our support for translations is nascent. We have an opportunity to get it right, or at least good enough, from the start.
Let me put something together to show you what I have in mind. In the meantime, I'd suggest delaying the merge of other
zh
page translations.Tasks
default_lang_commit
to front matter of all nonen
pages #4612Related
The text was updated successfully, but these errors were encountered: