-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider dropping support for protobuf 3 in opentelemetry-proto
#3074
Comments
Another issue with Zipkin exporter: Please make the latest versions available. |
@aabmass six months have passed, I think it is a good time to consider dropping support for protobuf 3 |
Why should we drop support for protobuf 3? Maybe just add support for protobuf 4 in this package opentelemetry-exporter-zipkin-proto-http? |
@daxartio this issue was specifically regarding the |
I don't mind that protobuf 3 will be dropped. But now i cannot use protobuf 4 because in the dependencies are written |
@daxartio if you are specifically talking about the zipkin exporter, can you please create a separate issue for that. I agree that it is a problem. |
Closing as support for protobuf5 was merged (which drop support for protobuf 3 and 4) 🚀 #4206 |
In #3070, we widened the supported version of protobuf to
protobuf>=3.19, < 5.0
based on votes and discussion in #2880 (comment) and #3050Long term, newer versions of
protoc
will not generate code that is compatible with older versions of protobuf library (see protocolbuffers/protobuf#11123 (comment)), meaning it will be hard to support both protobuf 3.x and 4.x. There are possible workarounds for this likeopentelemetry-proto
and making releases against both major versions with separate protoc compilers.The alternative is to drop support for protobuf 3 altogether at some reasonable point in the future, say 6 months.
The text was updated successfully, but these errors were encountered: