Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private tokens could appear in logs if context containing gRPC metadata is logged in github.com/grpc/grpc-go #1423

Closed
shenyutong10086 opened this issue Jul 11, 2024 · 2 comments · Fixed by #1420
Assignees
Labels
bug Something isn't working

Comments

@shenyutong10086
Copy link

Describe the bug
This issue represents a potential PII concern. If applications were printing or logging a context containing gRPC metadata, the affected versions will contain all the metadata, which may include private information.

Steps to reproduce
The issue first appeared in 1.64.0 and is patched in 1.64.1 and 1.65.0

What did you expect to see?
If using an affected version and upgrading is not possible, ensuring you do not log or print contexts will avoid the problem.

@shenyutong10086 shenyutong10086 added the bug Something isn't working label Jul 11, 2024
@johnli-developer
Copy link

Please assign this to me

@johnli-developer
Copy link

The bot already created a PR #1420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants