-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property based method invocation counter #8687
Comments
my wish list would include changing the methods instrumentation to read its configuration from a yaml file (or wait until we have standard yaml file). e.g. I've also had interest in being able to specify the SpanKind for |
I want to solve this problem, but I think we should use |
@xiepuhuan that sounds great! |
In this PR, I see that
When using a query similar to promql, the class name and method name can be used as attributes for filtering and aggregation operations. |
I think we went away from this proposal in #11354, probably because: I think it's better to just make metric name one of the configuration options
let's use
I didn't follow this part? |
This feature would introduce a new configuration property that allows users to measure the number of invocations of their methods without having to modify source code. This will be similar to
otel.instrumentation.methods.include
, but just a light weight metric and not a full-fledged span.Propose config item:
otel.instrumentation.method.counters
. The format of the value should be identical to the format ofotel.instrumentation.methods.include
(eg.my.package.MyClass1[method1,method2];my.package.MyClass2[method3]
).Propose metric name:
my.pakage.ClassName.method.invocations
type = counter (monotonically increasing).The text was updated successfully, but these errors were encountered: