Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podLabels needed in order to deploy #923

Open
robertocamp opened this issue Oct 14, 2023 · 3 comments
Open

podLabels needed in order to deploy #923

robertocamp opened this issue Oct 14, 2023 · 3 comments
Labels
chart:demo Issues related to opentelemetry-demo helm chart enhancement New feature or request

Comments

@robertocamp
Copy link

similar to "Unable to add custom labels to Opentelemetry Collector #862" (you may combine the two issues if that makes sense):

We are unable to deploy the Demo in our environment because we have a requirement that all pods and services have a certain custom label configured (otherwise a webhook prevents the resource from getting deployed).

Can you add this functionality to the Helm chart?

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "1"
    meta.helm.sh/release-name: opentelemetry-demo
    meta.helm.sh/release-namespace: otel-demo
  creationTimestamp: "2023-10-13T21:07:26Z"
  generation: 1
  labels:
    app.kubernetes.io/instance: opentelemetry-demo
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: otelcol
    app.kubernetes.io/version: 0.86.0
    helm.sh/chart: opentelemetry-collector-0.69.1
    custom_label:  value
@TylerHelmuth TylerHelmuth added enhancement New feature or request chart:demo Issues related to opentelemetry-demo helm chart labels Oct 14, 2023
@JaredTan95
Copy link
Member

Similarly, I'll finish this after #968 merged

@denizin42
Copy link

I'm adding a bump for this functionality. It looks like #968 was merged. Can we add this additional functionality as I too am prevented from deploying without some custom labels on the deployment resource? Thank you.

@JaredTan95
Copy link
Member

JaredTan95 commented Mar 4, 2024

I'm adding a bump for this functionality. It looks like #968 was merged. Can we add this additional functionality as I too am prevented from deploying without some custom labels on the deployment resource? Thank you.

Sure, I will support it in a few days. And if you're interested, welcome to contribute~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:demo Issues related to opentelemetry-demo helm chart enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants