-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[demo] support custom default pod label in pod #751
[demo] support custom default pod label in pod #751
Conversation
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Istio support was #715 about a month ago. Can you do a helm repo update and try again? |
Seeing that Istio has moved from Annotations to Labels to do sidecar injection, this PR makes sense, but we need to make some changes to it. We need to add an entry for each relevant component to add the default labels, similar to how we do it for env.
We should also add a doc section in the readme on how to use the Istio injection, noting to set up the labels in the default section, and ensuring the proper components have it enabled at their level. The |
7f43047
to
4e5c3df
Compare
@puckpuck please take another look |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
support costum default pod label for istio sidecar injection case
close #750