Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] support custom default pod label in pod #751

Closed

Conversation

Frapschen
Copy link
Contributor

@Frapschen Frapschen commented Apr 18, 2023

support costum default pod label for istio sidecar injection case

close #750

@Frapschen Frapschen requested a review from a team April 18, 2023 08:45
@Frapschen Frapschen requested a review from puckpuck as a code owner April 18, 2023 08:45
@github-actions
Copy link

github-actions bot commented May 5, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 5, 2023
@github-actions github-actions bot removed the Stale label May 6, 2023
@puckpuck
Copy link
Contributor

puckpuck commented May 9, 2023

Istio support was #715 about a month ago. Can you do a helm repo update and try again?

@puckpuck
Copy link
Contributor

Seeing that Istio has moved from Annotations to Labels to do sidecar injection, this PR makes sense, but we need to make some changes to it.

We need to add an entry for each relevant component to add the default labels, similar to how we do it for env.

    useDefault:
      env: true
      podLabels: true

We should also add a doc section in the readme on how to use the Istio injection, noting to set up the labels in the default section, and ensuring the proper components have it enabled at their level. The frontend, ffsPostgres, and redis components probably don't make sense for istio injection.

@Frapschen Frapschen force-pushed the support_default_pod_labels branch from 7f43047 to 4e5c3df Compare May 29, 2023 06:08
@TylerHelmuth TylerHelmuth requested review from dmitryax and povilasv May 30, 2023 15:17
@TylerHelmuth
Copy link
Member

@puckpuck please take another look

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 22, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[demo] support custom default pod label in pod
5 participants