Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo] support custom default pod label in pod #750

Open
Frapschen opened this issue Apr 18, 2023 · 2 comments
Open

[demo] support custom default pod label in pod #750

Frapschen opened this issue Apr 18, 2023 · 2 comments
Labels
chart:demo Issues related to opentelemetry-demo helm chart

Comments

@Frapschen
Copy link
Contributor

support costum default pod label for istio injection case
@Frapschen Frapschen mentioned this issue Apr 18, 2023
Closed
@TylerHelmuth TylerHelmuth added the chart:demo Issues related to opentelemetry-demo helm chart label Apr 18, 2023
@puckpuck
Copy link
Contributor

puckpuck commented May 9, 2023

Istio support was added about a month ago. Can you do a helm repo update and try again?

@Frapschen
Copy link
Contributor Author

Istio support was #715 about a month ago.

#715 is about making service name align istio's standard, not about adding an istio sidecar inject label, if I'm wrong, please correct me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chart:demo Issues related to opentelemetry-demo helm chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[demo] support custom default pod label in pod Frapschen/opentelemetry-helm-charts
3 participants
@puckpuck @TylerHelmuth @Frapschen