Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the K8s attribute processor #728

Open
martinjt opened this issue Apr 5, 2023 · 3 comments
Open

Enable the K8s attribute processor #728

martinjt opened this issue Apr 5, 2023 · 3 comments
Labels
chart:collector Issue related to opentelemetry-collector helm chart

Comments

@martinjt
Copy link
Member

martinjt commented Apr 5, 2023

It would be great if the attribute processor was included and configured by default. This would mean that all the spans get a tonne of extra k8s information like pods, start times etc. that allows us to showcase a lot of the benefits of the collector and k8s and also tracing/metrics correlation.

@TylerHelmuth TylerHelmuth added chart:demo Issues related to opentelemetry-demo helm chart chart:collector Issue related to opentelemetry-collector helm chart and removed chart:demo Issues related to opentelemetry-demo helm chart labels Apr 5, 2023
@TylerHelmuth
Copy link
Member

@martinjt the k8sattributes processor has RBAC permissions that aren't suitable for a default install of the collector, but we do have the k8sattributes processor as a preset. You can do

mode: daemonset
presets:
  kubernetesAttributes:
    enabled: true

and it will be added to the configuration for you and all the necessary changes will be made to the clusterrole/clusterrolebinding.

@puckpuck
Copy link
Contributor

puckpuck commented Apr 6, 2023

Should the demo include this preset by default?

@TylerHelmuth
Copy link
Member

Enabling this preset by default would require installing the clusterRole and clusterRoleBinding which, in my opinion, aren't appropriate for a default install. We should keep the default version of the chart as accessible as possible for any user who wants to try out the collector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:collector Issue related to opentelemetry-collector helm chart
Projects
None yet
Development

No branches or pull requests

3 participants