Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing variables and doc for endpoint credentials #1469

Open
travisghansen opened this issue Dec 20, 2024 · 0 comments
Open

missing variables and doc for endpoint credentials #1469

travisghansen opened this issue Dec 20, 2024 · 0 comments

Comments

@travisghansen
Copy link

travisghansen commented Dec 20, 2024

https://github.com/open-telemetry/opentelemetry-operator/blob/main/cmd/otel-allocator/README.md#service--pod-monitor-endpoint-credentials

The pre-reqs described in that doc are not sufficient. The feature was not working and eventually I noticed the following in the logs:

Cert-Manager is not available to the operator, skipping adding to scheme.

I do indeed have cert-manager installed so the log was a bit perplexing. After digging through the code I found this: https://github.com/open-telemetry/opentelemetry-operator/blob/main/internal/autodetect/autodetectutils/utils.go which detects the service account name and only does so via env var. This should probably be documented in the above link.

In addition it may be good to have more seamless integration with the helm chart to autoset the env vars.

Alternatively, it may be easier to have the code decode the token file and pull the data out similar to reading the data from the namespace file.

manager:
  env:
    # these are required to make cert-manager detection work properly
    SERVICE_ACCOUNT_NAME: {{ .Release.Name }}
    NAMESPACE: {{ .Release.Namespace }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant