Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type in values.yaml comment #1450

Closed
timofey-drozhzhin opened this issue Dec 6, 2024 · 1 comment · Fixed by #1451
Closed

Change type in values.yaml comment #1450

timofey-drozhzhin opened this issue Dec 6, 2024 · 1 comment · Fixed by #1451

Comments

@timofey-drozhzhin
Copy link
Contributor

The values.yaml comment in opentelemetry-collector and opentelemetry-kube-stack charts improperly refer to k8sobjects receiver in singular form.

Current snippet (Bad)

# Adds the k8sobject receiver to the logs pipeline

Proposed snippet (Good)

# Adds the k8sobjects receiver to the logs pipeline

Since the receiver is called k8sobjects, it will be proper to call it that. Referring it in singular form, causes users like myself to add k8sobject (singular form) to config.service.pipelines.logs.receivers, resulting in errors.

@timofey-drozhzhin
Copy link
Contributor Author

I added a commit here #1451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant