[otlp] Remove the Google.Protobuf / Grpc packages, and replace the logs and metrics with the new implementation #6005
+514
−3,177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
| { | ||
| Guard.ThrowIfNull(options); | ||
| Guard.ThrowIfNull(httpClient); | ||
| Guard.ThrowIfNull(signalPath); | ||
|
|
||
| Uri exporterEndpoint = options.Endpoint.AppendPathIfNotPresent(signalPath); | ||
| Uri exporterEndpoint; | ||
| if (options.Protocol == OtlpExportProtocol.Grpc) |
There was a problem hiding this comment.
Added a logical condition here to honor the existing behavior.
There was a problem hiding this comment.
Curious how it got by tests before?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6005 +/- ##
==========================================
+ Coverage 85.15% 85.82% +0.67%
==========================================
Files 272 257 -15
Lines 12420 11690 -730
==========================================
- Hits 10576 10033 -543
+ Misses 1844 1657 -187
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
🎉 I do not have enough time to review it right now, but it is great to see this progress. |
|
It looks like the proto files are copied into two directories, unit test & benchmarks. |
CodeBlanch
reviewed
Dec 2, 2024
|
|
||
| this.thread = new Thread(this.RetryStoredRequests) | ||
| { | ||
| Name = $"OtlpExporter Persistent Retry Storage - {typeof(TRequest)}", | ||
| Name = $"OtlpExporter Persistent Retry Storage", |
CodeBlanch
reviewed
Dec 2, 2024
| @@ -156,7 +156,7 @@ dotnet_diagnostic.IDE0005.severity = warning | |||
| # RS0041: Public members should not use oblivious types | |||
| dotnet_diagnostic.RS0041.severity = suggestion | |||
|
|
|||
| [obj/**.cs] | |||
| [**/obj/**.cs] | |||
There was a problem hiding this comment.
@rajkumar-rangaraj This cleans up those proto warnings you had to suppress in project files.
CodeBlanch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5730
Design discussion issue #
Changes
Please provide a brief description of the changes here.
OpenTelemetry.Exporter.OpenTelemetryProtocol
Tests / Benchmarks
Google.Protobuf,Grpc,Grpc.ToolsandGrpc.Net.Client.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes