Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.WCF] Bump System.* packages to 8.0.0 #2274

Open
Kielek opened this issue Oct 30, 2024 · 0 comments
Open

[Instrumentation.WCF] Bump System.* packages to 8.0.0 #2274

Kielek opened this issue Oct 30, 2024 · 0 comments
Labels
comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf

Comments

@Kielek
Copy link
Contributor

Kielek commented Oct 30, 2024

But also consider bumping to 8.0.0 versions for net8.0+:

  <ItemGroup Condition="'$(TargetFramework)' == '$(NetStandardMinimumSupportedVersion)'">
    <PackageReference Include="System.ServiceModel.Primitives" Version="4.7.0" />

    <!-- System.Security.Cryptography.Xml is indirect reference. It is needed to upgrade it directly to avoid https://github.com/advisories/GHSA-rxg9-xrhp-64gj -->
    <PackageReference Include="System.Security.Cryptography.Xml" Version="4.7.1" />
  </ItemGroup>

  <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
    <PackageReference Include="System.ServiceModel.Primitives" Version="8.0.0" />

    <!-- System.Security.Cryptography.Xml is indirect reference. It is needed to upgrade it directly to avoid https://github.com/advisories/GHSA-555c-2p6r-68mm -->
    <PackageReference Include="System.Security.Cryptography.Xml" Version="8.0.2" />
  </ItemGroup>

The 8.0.0 versions don't bring in System.Drawing.Common at all. The current form will force System.Drawing.Common onto users who may have already bumped to 8.0.0 to eliminate it 🤔

Originally posted by @CodeBlanch in #2263 (comment)

@Kielek Kielek added the comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf
Projects
None yet
Development

No branches or pull requests

1 participant