Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade otel-webserver-module CI to opentelemetry-cpp 1.15.0 #433

Open
marcalff opened this issue Apr 24, 2024 · 1 comment
Open

[CI] Upgrade otel-webserver-module CI to opentelemetry-cpp 1.15.0 #433

marcalff opened this issue Apr 24, 2024 · 1 comment
Assignees
Labels
bug Something isn't working Webserver This represents the otel-webserver-module in the instrumentation directory

Comments

@marcalff
Copy link
Member

marcalff commented Apr 24, 2024

Upgrade otel-webserver-module CI to opentelemetry-cpp 1.15.0.

If possible, please use semantic conventions from opentelemetry-cpp, instead of local constants such as:

const std::string kServiceName = "service.name";

as found in SdkConstants.h.

See opentelemetry-cpp header file opentelemetry/sdk/resource/semantic_conventions.h

https://github.com/open-telemetry/opentelemetry-cpp/blob/main/sdk/include/opentelemetry/sdk/resource/semantic_conventions.h

@marcalff marcalff added bug Something isn't working Webserver This represents the otel-webserver-module in the instrumentation directory labels Apr 24, 2024
@aryanishan1001
Copy link
Contributor

I will look into it and make the required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Webserver This represents the otel-webserver-module in the instrumentation directory
Projects
None yet
Development

No branches or pull requests

3 participants