-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for b3multi #36
Comments
kuzaxak
added a commit
to x-qdo/opentelemetry-cpp-contrib
that referenced
this issue
Feb 1, 2022
Some services expect [B3 Multi][1] headers as input information. To support that we need to be able to Inject them into upstream requests. Tests will be added as a separate commit later on. Solving open-telemetry#36 [1]: https://github.com/openzipkin/b3-propagation#multiple-headers
kuzaxak
added a commit
to x-qdo/opentelemetry-cpp-contrib
that referenced
this issue
Feb 1, 2022
Some services expect [B3 Multi][1] headers as input information. To support that we need to be able to Inject them into upstream requests. Lowercase headers used to be [compatible][2] with Istio Envoy. Tests will be added as a separate commit later on. Solving open-telemetry#36 [1]: https://github.com/openzipkin/b3-propagation#multiple-headers [2]: open-telemetry/opentelemetry-go#765
kuzaxak
added a commit
to x-qdo/opentelemetry-cpp-contrib
that referenced
this issue
Sep 8, 2022
Some services expect [B3 Multi][1] headers as input information. To support that we need to be able to Inject them into upstream requests. Lowercase headers used to be [compatible][2] with Istio Envoy. Tests will be added as a separate commit later on. Solving open-telemetry#36 [1]: https://github.com/openzipkin/b3-propagation#multiple-headers [2]: open-telemetry/opentelemetry-go#765
@ThomsonTan Could you please have a look? |
seemk
added a commit
that referenced
this issue
Dec 5, 2024
* Add support for B3Multi headers propagation Some services expect [B3 Multi][1] headers as input information. To support that we need to be able to Inject them into upstream requests. Lowercase headers used to be [compatible][2] with Istio Envoy. Tests will be added as a separate commit later on. Solving #36 [1]: https://github.com/openzipkin/b3-propagation#multiple-headers [2]: open-telemetry/opentelemetry-go#765 * add tests for b3 multi propagation --------- Co-authored-by: Vladimir Kuznichenkov <[email protected]> Co-authored-by: Vladimir Kuznichenkov <[email protected]>
Fixed with #495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
Need support for b3-multi for nginx module. https://github.com/openzipkin/b3-propagation#multiple-headers
Describe the solution you'd like
Implement b3-multi in similar fashion like it is with simple b3 just do not concat trace-span-sampled into on header.
Right now header looks like
for b3-multi there should be 3 headers
The text was updated successfully, but these errors were encountered: