Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other issue]: Layer are not in buildng_map-tools level #498

Open
1 task done
cwrx777 opened this issue Jun 6, 2024 · 1 comment
Open
1 task done

[Other issue]: Layer are not in buildng_map-tools level #498

cwrx777 opened this issue Jun 6, 2024 · 1 comment

Comments

@cwrx777
Copy link
Contributor

cwrx777 commented Jun 6, 2024

Before proceeding, is there an existing issue or discussion for this?

Description

To implement and add layer in level.

@luca-della-vedova
Copy link
Member

Hello!

Just thought I'd bring up that I did a bit of experimenting with this and the main challenge I found is in publishing the images.
Specifically, when populating images in the Level message that the building_map_server publishes to downstream packages.

It is true that the message is designed as an array, however since until now only a single image has been present for each floor (its reference drawing) the code paths to exploit the array property are not really tested.
Specifically I encountered exceptions in rmf_visualization in the image blending path (since it never got triggered before) and it is unclear to me how rmf-web would behave if multiple images are sent.
Still, I agree this would be a very useful feature! Just thought I'd share my findings if you plan to work on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants