Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation error: <instantiation>:16:5: error: instruction requires: sha3 #1933

Open
fwh-dc opened this issue Sep 25, 2024 · 4 comments · May be fixed by #1934
Open

Compilation error: <instantiation>:16:5: error: instruction requires: sha3 #1933

fwh-dc opened this issue Sep 25, 2024 · 4 comments · May be fixed by #1934

Comments

@fwh-dc
Copy link

fwh-dc commented Sep 25, 2024

Describe the bug

Compilation for ios fails:

13:23:30  liboqs/src/kem/kyber/oldpqclean_kyber512_aarch64/feat.S:147:5: note: while in macro instantiation
13:23:30      round
13:23:30      ^
13:23:30  <instantiation>:16:5: error: instruction requires: sha3
13:23:30      rax1.2d v29, v27, v29 ; d[3] = rotl(p[4], 1) ^ p[2]

I've found this stackoverflow question that suggests adding sha3 to the -march option. Doing that seems to solve the issue.

Additional question:
We want to support macos and ios arm/intel variants. How do we add some CI pipeline that tests compilation for those platforms?
@fwh-dc fwh-dc linked a pull request Sep 25, 2024 that will close this issue
Draft
2 tasks
@SWilson4
Copy link
Member

Hi @fwh-dc, thanks for the report. Could you please provide details about your environment and your build commands so that I can try to reproduce the error?

@fwh-dc
Copy link
Author

fwh-dc commented Sep 26, 2024

I am running XCode 16 on an intel mac with macos 14.

Here's the toolchain files + the cmake cache.
cmake-env.zip

Please let me know if you need more.

@baentsch
Copy link
Member

We want to support macos and ios arm/intel variants. How do we add some CI pipeline that tests compilation for those platforms?

I'm a bit surprised: I thought we already have that. Did you check out https://github.com/open-quantum-safe/liboqs/blob/main/.github/workflows/apple.yml and https://github.com/open-quantum-safe/liboqs/blob/main/.github/workflows/macos.yml ? Any enhancements e.g. testing setups not tested obviously welcome by PR.

@fwh-dc
Copy link
Author

fwh-dc commented Sep 26, 2024

We want to support macos and ios arm/intel variants. How do we add some CI pipeline that tests compilation for those platforms?

I'm a bit surprised: I thought we already have that. Did you check out https://github.com/open-quantum-safe/liboqs/blob/main/.github/workflows/apple.yml and https://github.com/open-quantum-safe/liboqs/blob/main/.github/workflows/macos.yml ? Any enhancements e.g. testing setups not tested obviously welcome by PR.

No I did not see those. Ok so probably our toolchainfile is different from yours. Thanks for the pointer. I'll need some time to get a better understanding of what is wrong. But good to know that there is support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
liboqs planning
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds sha3 to arm compile options which is needed for ios compilation. fwh-dc/liboqs
3 participants
@SWilson4 @fwh-dc @baentsch