-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos and remove fullwidth unicode chars #1488
Merged
zhouzaida
merged 5 commits into
open-mmlab:main
from
evdcush:fix/evdcush/correct-src-typos-and-remove-fullwidth-chars
Feb 18, 2024
Merged
Fix typos and remove fullwidth unicode chars #1488
zhouzaida
merged 5 commits into
open-mmlab:main
from
evdcush:fix/evdcush/correct-src-typos-and-remove-fullwidth-chars
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evdcush
requested review from
Harold-lkk,
HAOCHENYE,
C1rN09 and
zhouzaida
as code owners
February 7, 2024 22:02
evdcush
changed the title
Fix/evdcush/correct src typos and remove fullwidth chars
Fix typos and remove fullwidth unicode chars
Feb 7, 2024
@Harold-lkk @HAOCHENYE @C1rN09 @zhouzaida May I receive a review please? |
Hi @evdcush , thanks for your contribution. Last week we were on vacation and I am reviewing this PR now. |
zhouzaida
reviewed
Feb 18, 2024
zhouzaida
reviewed
Feb 18, 2024
Hi @zhouzaida, thank you for your review! 🙇🏻♂️ I have undone the diffs you mentioned as potential BC. |
zhouzaida
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are "fullwidth" unicode characters (mostly punctuation symbols) used in various places in MMEngine's documentation. These characters should not be used in EN documentation, as they are not generally supported by various documentation builds, such as
latexpdf
, and can cause issues with static analysis tools.There are also various fixes to typos included in this branch, including some to paths in source code.
Related to #1018
Modification
Fix module name and importthese have been reverted to avoid BCBC-breaking (Optional)
N/A
Use cases (Optional)
N/A
Checklist