Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support using other file handlers #1188

Merged
merged 12 commits into from
Aug 30, 2023

Conversation

KevinNuNu
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

在应用上线后不能让日志文件大小无限增大,需要对日志按要求进行分割。

Modification

为MMLogger增加一个接口使得支持日志分割。

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@KevinNuNu KevinNuNu requested a review from HAOCHENYE as a code owner June 3, 2023 07:36
@KevinNuNu KevinNuNu requested a review from C1rN09 as a code owner June 3, 2023 07:42
mmengine/logging/logger.py Outdated Show resolved Hide resolved
mmengine/logging/logger.py Outdated Show resolved Hide resolved
@HAOCHENYE
Copy link
Collaborator

Hi! Please follow the guide in contributing.md to fix the lint error

@KevinNuNu
Copy link
Contributor Author

Hi! Please follow the guide in contributing.md to fix the lint error

I got a pre-commit error i don't know how to fix.
image

@KevinNuNu KevinNuNu requested a review from zhouzaida as a code owner June 21, 2023 09:18
@zhouzaida zhouzaida added this to the 0.8.5 milestone Aug 23, 2023
@zhouzaida zhouzaida changed the title [Feature] add an interface to rotate log file for MMLogger [Feature] Support using other file handlers Aug 30, 2023
@zhouzaida zhouzaida merged commit 8a7e80e into open-mmlab:main Aug 30, 2023
8 of 9 checks passed
@KevinNuNu KevinNuNu deleted the rotate_log_file branch September 1, 2023 17:20
@fanqiNO1 fanqiNO1 mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants