PR Feedback Fixes

open-ibc · Sep 23, 2024 · ed0c7ee · ed0c7ee
1 parent 9b040f1
commit ed0c7ee
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/contracts/examples/Earth.sol b/contracts/examples/Earth.sol
@@ -101,6 +101,7 @@ contract Earth is IbcUniversalPacketReceiverBase {
      * @param channelId The channel ID.
      * @param packet The universal packet.
      * @return ackPacket The acknowledgement packet.
+     * @return skipAck Whether to skip the writeAck event.
      * @dev It's recommended to always validate the authorized channel of any packet or channel using the
      * onlyAuthorizedChannel modifier.
      */

diff --git a/contracts/examples/Mars.sol b/contracts/examples/Mars.sol
@@ -76,6 +76,7 @@ contract Mars is IbcReceiverBase, IbcReceiver, FeeSender {
      * @notice Callback for receiving a packet; triggered when a counterparty sends an an IBC packet
      * @param packet The IBC packet received
      * @return ackPacket The acknowledgement packet generated in response
+     * @return skipAck Whether to skip the writeAck event.
      * @dev Make sure to validate packet's source and destiation channels and ports.
      */
     function onRecvPacket(IbcPacket memory packet)

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@open-ibc/vibc-core-smart-contracts",
-  "version": "3.0.6",
+  "version": "4.0.0",
   "main": "dist/index.js",
   "bin": {
     "verify-vibc-core-smart-contracts": "./dist/scripts/verify-contract-script.js",