Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Unicode 11.0 Beta files #219

Closed
behnam opened this issue Apr 5, 2018 · 5 comments
Closed

Test Unicode 11.0 Beta files #219

behnam opened this issue Apr 5, 2018 · 5 comments
Assignees
Labels
A: source-data Source Data C: emoji Unicode Emoji C: idna IDNA: Internationalized Domain Names in Applications C: ucd Unicode Character Database L: easy Level: Easy
Milestone

Comments

@behnam
Copy link
Member

behnam commented Apr 5, 2018

We want to test new Unicode 11.0 data to make sure:

  • UNIC is compatible with new data.
  • There are no errors in the source data.

Source data files:

See Also:

@behnam behnam added help wanted C: ucd Unicode Character Database C: collation Text Collation L: easy Level: Easy C: emoji Unicode Emoji A: source-data Source Data C: idna IDNA: Internationalized Domain Names in Applications good first issue labels Apr 5, 2018
@behnam behnam added this to the Unicode-11.0 milestone Apr 5, 2018
@CAD97
Copy link
Collaborator

CAD97 commented Apr 5, 2018

Assuming everything goes perfectly, it should be as simple as changing one line...

https://github.com/behnam/rust-unic/blob/a2d51096c5e3f8faf727f87e716ed6db5daf04bc/data/sources.toml#L1-L3

and then rerunning the download script cargo run --package=unic-data.

@behnam
Copy link
Member Author

behnam commented Apr 6, 2018

Automated way wouldn't work that well, because the beta directories, although named similar to the normal release (:facepalm:), do not include all the files, but only those changed so far. So... needs manual work.

As a side note, @CAD97, the hyper client doesn't check HTTP Response status code and saves 404 HTML content into destinations. Would be good to just report and skip the file in those cases. What do you think? Filing another task for it?

@CAD97
Copy link
Collaborator

CAD97 commented Apr 6, 2018

Maybe I should have checked the directory before assuming 🙃 but it should be possible without touching the code just by modifying sources.toml to refer to and rename the files in question.

I filed #220 for handling bad responses.

@behnam behnam self-assigned this Apr 7, 2018
@behnam behnam removed the C: collation Text Collation label Apr 8, 2018
@Alexendoo
Copy link

Since unicode 11 was released, the directories now contain the final data

@eyeplum eyeplum mentioned this issue Mar 6, 2019
8 tasks
@behnam
Copy link
Member Author

behnam commented Apr 8, 2019

Tracking Unicode 11.0-related updates in #259. No need to keep this open anymore.

@behnam behnam closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: source-data Source Data C: emoji Unicode Emoji C: idna IDNA: Internationalized Domain Names in Applications C: ucd Unicode Character Database L: easy Level: Easy
Projects
None yet
Development

No branches or pull requests

3 participants