Bug/4810 changing textcase on form variable update #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmolen
changed the title
robinmolen
added
the
needs-backport
robinmolen
force-pushed
the
bug/4810-changing-textcase-with-objects-api-prefill
branch
from
16bda26 to
cb900c3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4837 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 748 748
Lines 25476 25477 +1
Branches 3368 3368
=======================================
+ Hits 24605 24607 +2
Misses 608 608
+ Partials 263 262 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
robinmolen
force-pushed
the
bug/4810-changing-textcase-with-objects-api-prefill
branch
2 times, most recently
from
b2d86fa to
ab29881
Compare
vaszig
requested changes
Nov 20, 2024
There was a problem hiding this comment.
It looks nice to me, only a couple of remarks (changes are only needed for the type checking if you agree as well)
For future bug fixes, it's nice to have a first commit with the regression test (which should fail) and then a second with the real fix of the bug.
robinmolen
force-pushed
the
bug/4810-changing-textcase-with-objects-api-prefill
branch
from
ab29881 to
a2c84db
Compare
vaszig
approved these changes
Nov 20, 2024
robinmolen
deleted the
bug/4810-changing-textcase-with-objects-api-prefill
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4810
Changes
The JSON parser on the form variables endpoint now ignores the
initial_valuefield. This ensures that the form variable initial value, and the default value of the component, stay exactly the same.Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene