Polish backend for soft-required validation #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
feature/4546-soft-required-validation-polish
branch
from
af53bc9 to
31dc3d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4801 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 748 748
Lines 25399 25406 +7
Branches 3354 3357 +3
=======================================
+ Hits 24525 24532 +7
Misses 609 609
Partials 265 265 ☔ View full report in Codecov by Sentry. |
* Make sure the HTML for the content is not treated as Django template * Make sure the component is not displayed in summary page/PDF report/ registration data etc. * Added tests
sergei-maertens
force-pushed
the
feature/4546-soft-required-validation-polish
branch
from
31dc3d0 to
fc2ffd7
Compare
|
Yeah lgtm 👍 |
robinmolen
approved these changes
Oct 29, 2024
sergei-maertens
deleted the
feature/4546-soft-required-validation-polish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4546
Changes
Tested this end-to-end with the SDK PR and noticed some more tweaks were needed.
registration data etc.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene