Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.msg files cannot be uploaded #4795

Open
LaurensBurger opened this issue Oct 25, 2024 · 2 comments · May be fixed by #4961
Open

.msg files cannot be uploaded #4795

LaurensBurger opened this issue Oct 25, 2024 · 2 comments · May be fixed by #4961
Assignees
@robinmolen
Labels
bug Something isn't working owner: utrecht

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Oct 25, 2024 •
edited
Loading

Product versie / Product version

tested on 2.7.x 2.8.x

Customer reference

Utr 306

Omschrijf het probleem / Describe the bug

Sentry: 313314

When uploading a .msg file and after navigating to the next step the upload component shows a error:
image

ValidationError {'data': {'bestandsupload': {0: {'type': [ErrorDetail(string="Het bestandstype kon niet bepaald worden. Controleer of de bestandsnaam met een extensie eindigt (bijvoorbeel '.pdf' of '.png').", code='blank')]}}}}

Tested with multiple OSes, and multiple files and environments.
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Oct 25, 2024
@joeribekker
Copy link
Contributor

Resembles #4773

@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Oct 28, 2024
@sergei-maertens sergei-maertens self-assigned this Dec 19, 2024
@sergei-maertens
Copy link
Member

I'll provide a .msg file

@robinmolen robinmolen moved this from Todo to In Progress in Development Dec 19, 2024
@sergei-maertens sergei-maertens removed their assignment Dec 19, 2024
robinmolen added a commit that referenced this issue Dec 19, 2024
@robinmolen
🧪 [#4795] Add test for msg file upload
ba649e5
robinmolen added a commit that referenced this issue Dec 19, 2024
@robinmolen
🧪 [#4795] Add test for msg file upload
b4b7a8a
robinmolen added a commit that referenced this issue Dec 19, 2024
@robinmolen
🧪 [#4795] Add test for msg file upload
26063d9
robinmolen added a commit that referenced this issue Dec 19, 2024
@robinmolen
🐛 [#4795] Validate .msg file type only on backend
afdda94 
The sdk cannot determine which content type belongs to a .msg file. This is because (at least) Linux and MacOS don't know this file type.

To make sure these files can be uploaded, the type property on the FileSerializer is now optional. For .smg files a new rule has been added to the MimeTypeValidator
@robinmolen robinmolen linked a pull request Dec 19, 2024 that will close this issue
Open
10 tasks
robinmolen added a commit that referenced this issue Dec 19, 2024
@robinmolen
🌐 [#4795] Updated translations
6833a2c
@robinmolen robinmolen moved this from In Progress to Implemented in Development Dec 19, 2024
@robinmolen robinmolen moved this from Implemented to In Progress in Development Dec 19, 2024
robinmolen added a commit that referenced this issue Dec 23, 2024
@robinmolen
🐛 [#4795] Validate .msg file type only on backend
a83bba6 
The sdk cannot determine which content type belongs to a .msg file. This is because (at least) Linux and MacOS don't know this file type.

To make sure these files can be uploaded, the type property on the FileSerializer is now optional. For .smg files a new rule has been added to the MimeTypeValidator
robinmolen added a commit that referenced this issue Dec 23, 2024
@robinmolen
🌐 [#4795] Updated translations
b7b268c
robinmolen added a commit that referenced this issue Dec 23, 2024
@robinmolen
✅ [#4795] Add e2e test for msg file upload
4908172
robinmolen added a commit that referenced this issue Dec 23, 2024
@robinmolen
🐛 [#4795] Validate .msg file type only on backend
f4d64af 
The sdk cannot determine which content type belongs to a .msg file. This is because (at least) Linux and MacOS don't know this file type.

To make sure these files can be uploaded, the type property on the FileSerializer is now optional. For .smg files a new rule has been added to the MimeTypeValidator
robinmolen added a commit that referenced this issue Dec 23, 2024
@robinmolen
🌐 [#4795] Updated translations
0f13355
robinmolen added a commit that referenced this issue Dec 23, 2024
@robinmolen
✅ [#4795] Add e2e test for msg file upload
2d11d04
robinmolen added a commit that referenced this issue Dec 23, 2024
@robinmolen
✅ [#4795] Fix tests
784b49f
robinmolen added a commit that referenced this issue Dec 23, 2024
@robinmolen
✅ [#4795] Fix tests
cc51188
robinmolen added a commit that referenced this issue Dec 23, 2024
@robinmolen
✅ [#4795] Fix tests
5e77364
@robinmolen robinmolen moved this from In Progress to Implemented in Development Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
bug Something isn't working owner: utrecht
Projects
Development
Status: Implemented
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.msg file upload open-formulieren/open-forms
4 participants
@joeribekker @sergei-maertens @LaurensBurger @robinmolen